fix VITE_URL bug not getting set#22
Merged
Merged
Conversation
3 tasks
robmsmt
added a commit
that referenced
this pull request
May 18, 2026
PR #22 switched the SSR-side reads from import.meta.env to process.env to support runtime container injection (deploy once, env var set per container, no rebuild). That works in prod and dev deploys, but breaks make dummy-run: Astro/Vite loads frontend/.env into import.meta.env only — process.env is untouched. So locally the env var is invisible, PageLayout falls back to the prod default, that prod URL gets baked into window.__API_URL__ on every page, and the browser fetches prod. Read both with process.env first: runtime container injection still wins, but local .env now works too. No rebuild required for either mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.