Parallel experiments#57
Open
gottschali wants to merge 8 commits into
Open
Conversation
instead of a method on ETASSimulation we use another function as the target for the parallel execution. As a drawback we must pass all the required parameters explicitly. this yields a small performance improvement.
Curiously, pydantic is not install automatically with hermes-model as it should be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some attempts at parallelizing the etas model, especially the simulation.
I wrote up about it in more detail here:
parallelization_notes/parallelization.md.This branch contains all changes and some reference files. So you probably don't want to merge this directly and only pick what's needed.
@lmizrahi my time at sed has ended, so @schmidni will take over now