Skip to content

chore(docs): add missing Figma link to Composable Footer documentation #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alionazherdetska
Copy link
Contributor

πŸ“„ Description

This PR adds the missing Figma design link to the Composable Footer documentation page in Storybook.

πŸ“ Checklist

  • βœ… My code follows the style guidelines of this project
  • πŸ› οΈ I have performed a self-review of my own code
  • πŸ“„ I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • πŸ§ͺ I have added tests that prove my fix is effective or that my feature works
  • βœ”οΈ New and existing unit tests pass locally with my changes

@alionazherdetska alionazherdetska requested review from a team as code owners April 17, 2025 12:26
@alionazherdetska alionazherdetska linked an issue Apr 17, 2025 that may be closed by this pull request
Copy link

changeset-bot bot commented Apr 17, 2025

πŸ¦‹ Changeset detected

Latest commit: 5d2594f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 17, 2025

Related Previews

@@ -3,7 +3,11 @@ import * as FooterStories from './footer.stories';

<Meta of={FooterStories}/>

# Composible Footer
<div className="docs-title">
# Composible Footer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Composible Footer
# Composable Footer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are not really related to your PR, but since you wrote it right in the changeset, could you correct the spelling on the docs as well? :)

# Composible Footer

<link-design of={JSON.stringify(FooterStories)}></link-design>
</div>

<p className="lead">The composible footer component for your Swiss Post page.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p className="lead">The composible footer component for your Swiss Post page.</p>
<p className="lead">The composable footer component for your Swiss Post page.</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer module in the docs is missing a figma link
3 participants