Skip to content

Conversation

@bucknatt
Copy link
Contributor

@bucknatt bucknatt commented Dec 5, 2025

📄 Description

The CSS .form-check-sm class is added to the Form Radio Button component. The variant Size has been added on the component's documentation.

🚀 Demo

For Radio Button
image

For Radio Group
image


🔮 Design review

  • Design review done
  • No design review needed

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@bucknatt bucknatt requested review from a team as code owners December 5, 2025 15:23
@bucknatt bucknatt requested a review from gfellerph December 5, 2025 15:23
@bucknatt bucknatt linked an issue Dec 5, 2025 that may be closed by this pull request
4 tasks
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

🦋 Changeset detected

Latest commit: 2f3add2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Minor
@swisspost/design-system-components Minor
@swisspost/internet-header Minor
@swisspost/design-system-nextjs-integration Minor
@swisspost/design-system-styles-primeng-workspace Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-changelog-github Minor
@swisspost/design-system-eslint Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 5, 2025

Related Previews

@leagrdv leagrdv requested review from leagrdv and removed request for gfellerph December 8, 2025 08:55
leagrdv
leagrdv previously requested changes Dec 8, 2025
Copy link
Contributor

@leagrdv leagrdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see in the screenshot (desktop) that the small version has the radio misaligned with the text.

You can go through the checklist of the ticket to make sure you've not forgotten any task. The last element "Design review" should be done by a designer: Once you've reviewed the design yourself to make sure what you've implemented looks the same as on figma, you can contact Sandra and ask her to review the small version of the component.
Capture d'écran 2025-12-08 103958

@sandra-post
Copy link
Contributor

Design Review
All looks good, except font size:

  • IS: 16 / 14 / 14
  • SHOULD: 14 / 14 / 14

I see that this has been missed to tokenize. I will therefore add the missing token.

@bucknatt bucknatt requested a review from leagrdv December 11, 2025 13:35
@leagrdv leagrdv requested review from alizedebray and removed request for leagrdv December 12, 2025 10:37
@leagrdv leagrdv dismissed their stale review December 12, 2025 10:38

Change of reviewer

fieldset .form-check-sm:not(.form-switch, .form-check-inline, :last-of-type) {
display: flex;
align-items: center;
margin-block-end: tokens.get('radio-button-small-group-items-gap-block');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you inspect the CSS, you can see that the margin-bottom set on the .form-check in the file _form-check.scss is overriding the margin-block-end you've defined for the .form-check-sm, meaning the gap between small elements within a fieldset is not correct.

When applying a property on an element, it's always good to use the inspector to make sure it is correctly applied, especially when the difference it brings might be hard to see.
Capture d'écran 2025-12-12 154050

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[html/css] Radio Button (small)

5 participants