Found and fixed 2 small possible bugs in the Solana example programs #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix seeds vector capacity in advanced-oracle-example utils.rs:52 Changed from feed_ids.len() + 1 to feed_ids.len() + 2 to account for queue key + feed_ids + bump seed - Fix randomness validation in sb-randomness lib.rs:65-72 Add proper check for randomness expiration vs already revealed Distinguish between expired randomness and already revealed randomness 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the advanced-oracle-example, utils.rs:52, the size of the seeds vector should be feed_ids.len() + 2 to account for queue key + feed_ids + bump seed rather than feed_ids.len() + 1.
In the coin flip randomness example, lib.rs:65-72, there is a check to make sure the randomness is fresh (from the last round), but should make sure the randomness is not already revealed, because this might allow an attack where the player reveals the randomness and then decides whether to commit their coin flip bet.