Skip to content

Conversation

@petruki
Copy link
Member

@petruki petruki commented Oct 5, 2025

This pull request refactors how snapshot data is structured and handled throughout the codebase, removing the unnecessary Data wrapper class and simplifying the model to use Domain directly within Snapshot. It also updates related serialization/deserialization logic, test fixtures, and configuration files to match the new structure. Additionally, several dependency versions are updated in the Maven configuration.

Model and Serialization Refactoring:

  • Removed the Data class (src/main/java/com/switcherapi/client/model/criteria/Data.java) and updated Snapshot to contain a Domain field directly, simplifying the data model and reducing nesting. [1] [2]
  • Updated deserialization logic in ClientWSImpl to handle the new structure by introducing a SnapshotDataResponse DTO, ensuring compatibility with the API response format. [1] [2]
  • Adjusted native image reflection configuration to remove references to Data and add SnapshotDataResponse. [1] [2]

Dependency and Build Updates:

  • Updated Maven dependencies and plugin versions in pom.xml for improved stability and compatibility (JUnit, Maven Compiler Plugin, Central Publishing Plugin, etc.).
  • Bumped project version to 2.5.0-SNAPSHOT in pom.xml.

Breaking change

Snapshot content before:

{
   "data": {
        "domain": {
            "name": "switcher-domain",
            "activated": true,
            "group": [...]
        }
    }
}

Snapshot content now:

{
    "domain": {
        "name": "switcher-domain",
        "activated": true,
        "group": [...]
    }
}

@petruki petruki added this to the v2.5.0 milestone Oct 5, 2025
@petruki petruki self-assigned this Oct 5, 2025
@petruki petruki added the enhancement New feature or request label Oct 5, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2025

@petruki petruki merged commit 1d12b71 into master-2 Oct 5, 2025
19 of 20 checks passed
@petruki petruki deleted the staging branch October 5, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants