Skip to content

Conversation

@petruki
Copy link
Member

@petruki petruki commented Oct 25, 2025

This pull request focuses on dependency upgrades, codebase modernization, and minor logic improvements throughout the application. The most significant changes involve updating major dependencies (including Angular and Apollo), replacing global browser references for better compatibility, and refining some logic for clarity and correctness.

Dependency upgrades:

  • Upgraded all Angular packages to version 20.3.7, Apollo Client to 4.0.7, Apollo Angular to 12.1.0, and other dependencies to their latest minor versions in package.json.
  • Updated the base Docker image in Dockerfile from nginx:1.29.1-alpine-slim to nginx:1.29.2-alpine-slim.

Codebase modernization and browser compatibility:

  • Replaced most usages of window with globalThis for browser APIs (such as innerWidth, screen, and history) across multiple components to improve compatibility and future-proof the code. [1] [2] [3] [4] [5] [6] [7] [8]

Logic and code improvements:

  • Refactored array iteration from .forEach to for...of loops for clarity and correctness in several components (ChangelogComponent, ComponentsComponent). [1] [2]
  • Improved array searching by replacing .filter(...)[0] with .find(...) for more idiomatic and efficient code. [1] [2]
  • Enhanced filtering logic in ChangelogComponent by switching from .indexOf checks to .includes and .some for better readability and reliability. [1] [2]

Form and editing logic fixes:

  • Updated edit logic in detail components (ConfigDetailComponent, RelayDetailComponent, StrategyDetailComponent) to return early when entering edit mode, preventing unintended execution of validation and update logic. [1] [2] [3]
  • Fixed conditional logic for updating configuration and metrics in ConfigDetailComponent. [1] [2]

Type and import corrections:

  • Corrected Apollo type usage in ElementAutocompleteComponent from ApolloQueryResult to Apollo.QueryResult. [1] [2]

@petruki petruki added this to the v2.1.1 milestone Oct 25, 2025
@petruki petruki self-assigned this Oct 25, 2025
@petruki petruki added documentation Improvements or additions to documentation enhancement New feature or request patch Dependecy upgrade labels Oct 25, 2025
@petruki petruki merged commit b6e50b7 into master Oct 25, 2025
3 checks passed
@petruki petruki deleted the staging branch October 25, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request patch Dependecy upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants