Skip to content

TextLayout: fix double scaling with SkijaGC#297

Draft
DenisUngemach wants to merge 4 commits intomasterfrom
fixes
Draft

TextLayout: fix double scaling with SkijaGC#297
DenisUngemach wants to merge 4 commits intomasterfrom
fixes

Conversation

@DenisUngemach
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Test Results

   369 files  ±0     369 suites  ±0   10m 23s ⏱️ - 1m 12s
 4 017 tests ±0   3 718 ✅ ±0  299 💤 ±0  0 ❌ ±0 
11 795 runs  ±0  10 859 ✅ ±0  936 💤 ±0  0 ❌ ±0 

Results for commit 8df3240. ± Comparison against base commit 783f638.

♻️ This comment has been updated with latest results.

- the TextLayout uses the ParagraphBuilder and then drawImage. There
SkiaGC scales the image. This is wrong in this case, because it causes a
doulbed scaling together with commit().
DenisUngemach and others added 3 commits July 9, 2025 14:26
cause empty Dialog windows sometimes.

It is critical to test this properly in eclipse, before this will be
change:
in eclipse switch between scaling factors and open the "new
project"-dialog multiple times.
@DenisUngemach DenisUngemach marked this pull request as draft July 11, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant