TextLayout: fix double scaling with SkijaGC#297
Draft
DenisUngemach wants to merge 4 commits intomasterfrom
Draft
TextLayout: fix double scaling with SkijaGC#297DenisUngemach wants to merge 4 commits intomasterfrom
DenisUngemach wants to merge 4 commits intomasterfrom
Conversation
- the TextLayout uses the ParagraphBuilder and then drawImage. There SkiaGC scales the image. This is wrong in this case, because it causes a doulbed scaling together with commit().
cause empty Dialog windows sometimes. It is critical to test this properly in eclipse, before this will be change: in eclipse switch between scaling factors and open the "new project"-dialog multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.