Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 7, 2026

Proposed changes

CI has been failing since the release of Numpy 2.4.

Fixes #6527.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the ci/cd Continuous integration & deployment label Jan 7, 2026
nilsdeppe
nilsdeppe previously approved these changes Jan 8, 2026
@wthrowe
Copy link
Member

wthrowe commented Jan 8, 2026

It's still failing, but now because of #6527.

@nilsvu
Copy link
Member Author

nilsvu commented Jan 8, 2026

Pushed a fix for #6527.

@nilsvu
Copy link
Member Author

nilsvu commented Jan 10, 2026

Merging to fix CI

@nilsvu nilsvu merged commit 7d2eaa1 into sxs-collaboration:develop Jan 10, 2026
22 of 24 checks passed
@nilsvu nilsvu deleted the fix_ci branch January 10, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration & deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit.Visualization.Python.PlotSlice - AttributeError: 'QuadContourSet' object has no attribute 'collections'

3 participants