Add PPM reconstruction#7103
Open
nilsdeppe wants to merge 3 commits into
Open
Conversation
jyoo1042
reviewed
Mar 18, 2026
| #include "Helpers/NumericalAlgorithms/FiniteDifference/Exact.hpp" | ||
| #include "Helpers/NumericalAlgorithms/FiniteDifference/Python.hpp" | ||
| #include "NumericalAlgorithms/FiniteDifference/Ppm.hpp" | ||
|
|
Contributor
There was a problem hiding this comment.
minor comment: since this test file uses std::array, gsl::not_null, gsl::span, and DataVector, we could include <array>, "Utilities/Gsl.hpp" and "DataStructures/DataVector.hpp"
Member
Author
There was a problem hiding this comment.
I've rebased and squashed in adding the includes. Did you get a chance to try this reconstructor out?
Implements a finite-difference Piecewise Parabolic Method (PPM) reconstructor using degree-2 quadratic interpolation through three point values, followed by the Colella & Woodward (1984) §1.4 monotonicity limiter adapted for FD point values (not FV cell averages). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds PpmPrim, a piecewise parabolic method (PPM) reconstructor for the GRMHD ValenciaDivClean system, following the same structure as MonotonisedCentralPrim. PPM uses a 3-point stencil with the Colella & Woodward monotonicity limiter (ghost_zone_size = 2, no adaptive order). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds PpmPrim, a piecewise parabolic method (PPM) reconstructor for the GRMHD GhValenciaDivClean system, following the same structure as MonotonisedCentralPrim. PPM uses a 3-point stencil with the Colella & Woodward monotonicity limiter (ghost_zone_size = 2, no adaptive order). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements a finite-difference Piecewise Parabolic Method (PPM) reconstructor using degree-2 quadratic interpolation through three point values, followed by the Colella & Woodward (1984) §1.4 monotonicity limiter adapted for FD point values (not FV cell averages).
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments