Create exponential filter function for ZernikeB2#7195
Merged
nilsdeppe merged 1 commit intoMay 11, 2026
Conversation
michaeldmurphy1
commented
Apr 15, 2026
|
|
||
| namespace Spectral::filtering { | ||
| namespace detail { | ||
| void apply_matrix_in_first_dim(double* result, const double* const input, |
Contributor
Author
There was a problem hiding this comment.
This is a copy-paste from PartialDerivatives.cpp. I am not aware of a similar wrapper in DataStructures or Utilities
michaeldmurphy1
force-pushed
the
b2_filtering
branch
from
2d8f6ed to
27a86f8
Compare
michaeldmurphy1
commented
Apr 20, 2026
| "[NumericalAlgorithms][Spectral][Unit]") { | ||
| // We test the filtering by verifying known outcomes (i.e. constants | ||
| // unaffected, highest modes completely zeroed) as well as testing | ||
| // individaul modes are scaled as expected |
michaeldmurphy1
force-pushed
the
b2_filtering
branch
from
27a86f8 to
32d5f9d
Compare
nilsdeppe
requested changes
May 7, 2026
Member
nilsdeppe
left a comment
nilsdeppe
left a comment
There was a problem hiding this comment.
A few minor things. Please squash and rebase immediately
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michaeldmurphy1
force-pushed
the
b2_filtering
branch
from
32d5f9d to
b203a05
Compare
nilsdeppe
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Functions represented with ZernikeB2 have a multidimensional spectral space, so the filtering is more involved...
I'm open to reworking how the functions are called (not sure how it will work in practice, but this worked for my cases).
Also is this the right file name / location?
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments