Skip to content

More descriptive error message for BBH headon#7226

Merged
wthrowe merged 1 commit into
sxs-collaboration:developfrom
JosePineda684:BBHHeadOnMsg
May 11, 2026
Merged

More descriptive error message for BBH headon#7226
wthrowe merged 1 commit into
sxs-collaboration:developfrom
JosePineda684:BBHHeadOnMsg

Conversation

@JosePineda684
Copy link
Copy Markdown
Contributor

Proposed changes

The following change addresses issue #6240 with a more clarifying error message in the event someone attempts to start a bbh headon collision with both orbital_angular_velocity=0 and eccentricity=0.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.
  • If a coding agent is used, have one of
    "Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
    "Co-Authored-by: Codex noreply@openai.com", or
    "Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
    as the last line of the commit, depending on the agent.

Further comments

Comment thread support/Pipelines/EccentricityControl/InitialOrbitalParameters.py Outdated
@JosePineda684 JosePineda684 requested a review from wthrowe May 11, 2026 17:21
@wthrowe wthrowe merged commit 2f165b8 into sxs-collaboration:develop May 11, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants