Add ZernikeB1 interpolation matrix#7232
Merged
nilsdeppe merged 2 commits intoMay 31, 2026
Merged
Conversation
michaeldmurphy1
force-pushed
the
zernikeb1_interp_mat
branch
from
45830a1 to
9409096
Compare
6 tasks
nilsdeppe
requested changes
May 26, 2026
Comment on lines
+227
to
+232
| const DataVector collocation_pts = | ||
| Zernike<Dim>::compute_collocation_points_and_weights(num_points).first + | ||
| 1.0; | ||
| // Build shifted target points in the same [0,2] coordinate system | ||
| const T shifted_target = target_points + 1.0; | ||
| DataVector extended_collocation_pts(2 * num_points, 0.0); |
Member
There was a problem hiding this comment.
Is it possible to combine the 3 DataVector-ish things into 1 allocation? The matrix here is also temp/internal, but I don't know if we can do non-owning Matrix.
michaeldmurphy1
force-pushed
the
zernikeb1_interp_mat
branch
from
9409096 to
dafeaac
Compare
nilsdeppe
reviewed
May 28, 2026
| sign * extended_diff_matrix(i, j + num_points); | ||
| } | ||
| } | ||
| extended_diff_matrix.resize(num_points, num_points, true); |
Member
There was a problem hiding this comment.
This does another allocation and copy. Can you restructure the loop on line 213 to do the "evaluate and fold" all at once?
Member
There was a problem hiding this comment.
Why not just make the matrix num_points X num_points to start now?
michaeldmurphy1
force-pushed
the
zernikeb1_interp_mat
branch
from
dafeaac to
8fec12e
Compare
nilsdeppe
reviewed
May 30, 2026
| sign * extended_diff_matrix(i, j + num_points); | ||
| } | ||
| } | ||
| extended_diff_matrix.resize(num_points, num_points, true); |
Member
There was a problem hiding this comment.
Why not just make the matrix num_points X num_points to start now?
| // Mirror xi around the symmetry point xi=-1 (r=0): xi' = -xi - 2. | ||
| DataVector extended_collocation_pts(2 * num_points); | ||
| { | ||
| const DataVector pts = |
Comment on lines
+241
to
+249
| Matrix result = | ||
| fornberg_interpolation_matrix(target_points, extended_collocation_pts); | ||
| const size_t num_target = result.rows(); | ||
| for (size_t i = 0; i < num_points; ++i) { | ||
| for (size_t k = 0; k < num_target; ++k) { | ||
| result(k, i) += sign * result(k, i + num_points); | ||
| } | ||
| } | ||
| result.resize(num_target, num_points, true); |
Member
There was a problem hiding this comment.
Same fold question as for the diff matrix. Can this also elide the resize?
Contributor
Author
There was a problem hiding this comment.
I don't think I can avoid the extra allocation...
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michaeldmurphy1
force-pushed
the
zernikeb1_interp_mat
branch
from
8fec12e to
46bfba7
Compare
nilsdeppe
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
To go between DG and Subcell grids, we need to project which requires an interpolation matrix for ZernikeB1.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments