Skip to content

Added coupling functions for ScalarGaussBonnet theory.#7254

Merged
wthrowe merged 1 commit into
sxs-collaboration:developfrom
FabrizioCorelli:test
Jun 15, 2026
Merged

Added coupling functions for ScalarGaussBonnet theory.#7254
wthrowe merged 1 commit into
sxs-collaboration:developfrom
FabrizioCorelli:test

Conversation

@FabrizioCorelli

@FabrizioCorelli FabrizioCorelli commented May 26, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Introduces the class representing the coupling function of Einstein-scalar-Gauss-Bonnet gravity. The class is abstract and factory creatable, so that it acts as an interface to be specialized for the different types of couplings. Two specializations are also provided: Exponential and QuarticPolynomial.

@guilara

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.
  • If a coding agent is used, have one of
    "Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
    "Co-Authored-by: Codex noreply@openai.com", or
    "Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
    as the last line of the commit, depending on the agent.

Further comments

@FabrizioCorelli FabrizioCorelli force-pushed the test branch 7 times, most recently from 11222cc to 4ecb544 Compare June 1, 2026 14:26
@FabrizioCorelli FabrizioCorelli changed the title Added coupling function structs for ScalarGaussBonnet theory. Added coupling functions for ScalarGaussBonnet theory. Jun 1, 2026
@FabrizioCorelli FabrizioCorelli marked this pull request as ready for review June 1, 2026 16:33
Comment thread src/PointwiseFunctions/ScalarTensor/ScalarGaussBonnet/CouplingFunctions/Tags.hpp Outdated
Comment thread src/PointwiseFunctions/ScalarTensor/ScalarGaussBonnet/CouplingFunctions/Tags.hpp Outdated
Comment thread src/PointwiseFunctions/ScalarTensor/ScalarGaussBonnet/ScalarGaussBonnet.hpp Outdated
Co-authored-by: Guillermo Lara <13457788+guilara@users.noreply.github.com>

@wthrowe wthrowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In the future, please submit extensive review changes as separate "fixup" commits. It makes the reviewer's job easier.

@wthrowe wthrowe merged commit 0fa37ba into sxs-collaboration:develop Jun 15, 2026
24 checks passed
@github-actions

Copy link
Copy Markdown

@FabrizioCorelli looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:

  1. Edit the Metadata.yaml file in the repository.
  2. Add an entry to the list in Authors.Contributors with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.
  3. Commit the change on a new branch and open a pull request with the change.

Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants