Added coupling functions for ScalarGaussBonnet theory.#7254
Merged
Conversation
11222cc to
4ecb544
Compare
wthrowe
requested changes
Jun 12, 2026
Co-authored-by: Guillermo Lara <13457788+guilara@users.noreply.github.com>
wthrowe
approved these changes
Jun 15, 2026
wthrowe
left a comment
Member
There was a problem hiding this comment.
Looks good.
In the future, please submit extensive review changes as separate "fixup" commits. It makes the reviewer's job easier.
|
@FabrizioCorelli looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:
Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduces the class representing the coupling function of Einstein-scalar-Gauss-Bonnet gravity. The class is abstract and factory creatable, so that it acts as an interface to be specialized for the different types of couplings. Two specializations are also provided:
ExponentialandQuarticPolynomial.@guilara
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments