Add waveform extraction to the bbh pipeline#7271
Open
JosePineda684 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@geoffrey4444 can you give a preliminary review? |
Contributor
|
@JosePineda684 can you please separate the combine H5 stuff into a separate commit? I ask because that is in a separate PR. This will make it easier for me to review the changes beyond that. |
Contributor
Author
|
@geoffrey4444 I can do that. I realize what I just attempted is not what you wanted, so I will try again later today! |
JosePineda684
force-pushed
the
add_cce_to_pipeline
branch
from
8193374 to
e93308e
Compare
Contributor
Author
|
@geoffrey4444 done! |
Co-Authored-by: Codex <noreply@openai.com>
JosePineda684
force-pushed
the
add_cce_to_pipeline
branch
from
c9b82eb to
9ff4008
Compare
geoffrey4444
requested changes
Jun 15, 2026
geoffrey4444
left a comment
geoffrey4444
left a comment
Contributor
There was a problem hiding this comment.
Nice first draft! I have some comments. After you address them, I think this is ready for a look by others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR addresses issue #5849 .The following edits streamline Cauchy Characteristic Evolution (CCE) after completing a bbh simulation by adding it to the pipeline. Relies on PR #7255.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.