Add ProjectSpectralFilter AMR projector#7289
Conversation
| /// - For h-refinement (splitting): clones the parent's filter for the child. | ||
| /// - For h-coarsening (joining): clones the first child's filter for the | ||
| /// parent (all siblings share the same block and mesh basis/quadrature, so | ||
| /// they carry identical filters). |
There was a problem hiding this comment.
The code supports (initial) radial refinement of B1, B2, and B3 (see here). Eventually this logic will need to be included for these operations.
This would mean both splitting and joining of these pairs of topologies
- Cylinder
$\leftrightarrow$ Cylinder + Hollow Cylinder - Ball
$\leftrightarrow$ Ball + Spherical Shell
This probably does not matter yet as the Bn radial refinement is not currently in any AMR logic.
There was a problem hiding this comment.
Yea, how to deal with h-refinement in these topology changing splits is something Larry, Will, and I have discussed a bit but haven't gotten consensus on. Probably we will try a few different things to see what works. We are ignoring issues related to that for now. I think we should hit an error that no filter is applied in an element
kidder
left a comment
There was a problem hiding this comment.
I have no requested changes and will approve after the dependent PR is in
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6376262 to
aa606b7
Compare
|
I've rebased this on the changes from #7285 |
The merge-base changed after approval.
Proposed changes
Only the AMR projector is new in this PR.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments