Skip to content

Add ProjectSpectralFilter AMR projector#7289

Open
nilsdeppe wants to merge 4 commits into
sxs-collaboration:developfrom
nilsdeppe:runtime_filtering_11
Open

Add ProjectSpectralFilter AMR projector#7289
nilsdeppe wants to merge 4 commits into
sxs-collaboration:developfrom
nilsdeppe:runtime_filtering_11

Conversation

@nilsdeppe

Copy link
Copy Markdown
Member

Proposed changes

Only the AMR projector is new in this PR.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.
  • If a coding agent is used, have one of
    "Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
    "Co-Authored-by: Codex noreply@openai.com", or
    "Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
    as the last line of the commit, depending on the agent.

Further comments

Comment on lines +29 to +32
/// - For h-refinement (splitting): clones the parent's filter for the child.
/// - For h-coarsening (joining): clones the first child's filter for the
/// parent (all siblings share the same block and mesh basis/quadrature, so
/// they carry identical filters).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code supports (initial) radial refinement of B1, B2, and B3 (see here). Eventually this logic will need to be included for these operations.

This would mean both splitting and joining of these pairs of topologies

  • Cylinder $\leftrightarrow$ Cylinder + Hollow Cylinder
  • Ball $\leftrightarrow$ Ball + Spherical Shell

This probably does not matter yet as the Bn radial refinement is not currently in any AMR logic.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, how to deal with h-refinement in these topology changing splits is something Larry, Will, and I have discussed a bit but haven't gotten consensus on. Probably we will try a few different things to see what works. We are ignoring issues related to that for now. I think we should hit an error that no filter is applied in an element

@kidder kidder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no requested changes and will approve after the dependent PR is in

nilsdeppe and others added 4 commits June 16, 2026 16:04
@nilsdeppe nilsdeppe force-pushed the runtime_filtering_11 branch from 6376262 to aa606b7 Compare June 16, 2026 21:05
@nilsdeppe

Copy link
Copy Markdown
Member Author

I've rebased this on the changes from #7285

kidder
kidder previously approved these changes Jun 16, 2026
@nilsdeppe nilsdeppe dismissed kidder’s stale review June 17, 2026 02:53

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants