Optimize ReadH5#7297
Closed
hen-w wants to merge 1 commit into
Closed
Conversation
Subfiles (.vol, .dat) are always top-level HDF5 groups. Replace h5file.visit() with h5file.keys() to avoid recursively walking every dataset in the file, which is extremely slow on ZFS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hen-w
added
the
small
Contributor
Author
|
Actually we cannot assume all subfiles are in top-level HDF5 groups. So the best way to avoid wasting time to find the correct subfile is to specify the subfile whenever possible. For example, always specify -d for generate-xdmf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subfiles (.vol, .dat) are always top-level HDF5 groups. Replace h5file.visit() with h5file.keys() to avoid recursively walking every dataset in the file, which is extremely slow on ZFS.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments