CCE: compute boundary Du<Dy<J>> from buffered R and Dr<J>#7300
Closed
gda98re wants to merge 1 commit into
Closed
Conversation
Adds `Tags::Du<Tags::Dy<Tags::BondiJ>>` to
`characteristic_worldtube_boundary_tags` (needed by `CauchySecondOrder`
and other future generators) and computes its boundary value.
The boundary value of `Tags::Du<Tags::Dy<Tags::BondiJ>>` is no longer
read from the worldtube h5 file. Instead `BondiWorldtubeDataManager`
computes it directly from quantities already in the buffer:
- At every buffered time inside the current interpolation sub-window,
extract the modes of `R` and `Dr<BondiJ>` from
`coefficients_buffers_`, convert them from Goldberg to libsharp
layout, and inverse-SWSH-transform to nodal values at the boundary.
- Form the nodal product `dy_j = 0.5 * R * Dr<BondiJ>` at each
buffered time.
- At every angular collocation point, call the new
`SpanInterpolator::derivative` on the resulting time series to
obtain the time derivative at the requested time, which is written
into `BoundaryValue<Du<Dy<BondiJ>>>`.
`worldtube_boundary_tags_for_writing` and the `BondiWorldtubeH5BufferUpdater`
dataset map no longer carry the now-removed `DuDyJ` channel.
`create_bondi_boundary_data` does not populate `Du<Dy<BondiJ>>`, so the
boundary-comparison loops that build their "expected" Variables from it
exclude that tag via `tmpl::list_difference` (with a comment explaining
why): `Test_WorldtubeData`, `Test_AnalyticBoundaryDataManager`, and the
H5 / Gh / Analytic `*BoundaryCommunication` tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Tags::Du<Tags::Dy<Tags::BondiJ>>tocharacteristic_worldtube_boundary_tags(needed byCauchySecondOrder) and computes its boundary value.The boundary value of
Tags::Du<Tags::Dy<Tags::BondiJ>>is computed directly byBondiWorldtubeDataManagerfrom quantities already in the buffer:RandDr<BondiJ>fromcoefficients_buffers_, convert them from Goldberg to libsharp layout, and inverse-SWSH-transform to nodal values at the boundary.dy_j = 0.5 * R * Dr<BondiJ>at each buffered time.SpanInterpolator::derivativeon the resulting time series to obtain the time derivative at the requested time, which is written intoBoundaryValue<Du<Dy<BondiJ>>>.create_bondi_boundary_datadoes not populateDu<Dy<BondiJ>>, so the boundary-comparison loops that build their "expected" Variables from it exclude that tag viatmpl::list_difference(with a comment explaining why):Test_WorldtubeData,Test_AnalyticBoundaryDataManager, and the H5 / Gh / Analytic*BoundaryCommunicationtests.Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments