PATCH M2M for bug 52. #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sy2002#52 What I see is that the drive wants to save its data, so the qnice code iterates over the track buffer to fetch all the data. However when it is finished, and the address is pointing at the last byte of the track buffer, it strobes the ACK signal. And since the write enable is still on, this actually activates a write into the track buffer... corrupting it. Fix: explicitly reset write enable VD_B_WREN (sd_buff_wr in the drive). Leave the XOR bug as it is, so that write enable remains on all the time during writing into the disk's buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
What I see is that the drive wants to save its data, so the qnice code iterates over the track buffer to fetch all the data. However when it is finished, and the address is pointing at the last byte of the track buffer, it strobes the ACK signal. And since the write enable is still on, this actually activates a write into the track buffer... corrupting it.
Fix: explicitly reset write enable VD_B_WREN (sd_buff_wr in the drive). Leave the XOR bug as it is, so that write enable remains on all the time during writing into the disk's buffer.