Update syb.config.xml #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found no clients or tests for this. But System.gc() by itself does nothing, so the original version clearly does not work as intended. The revised version may. Bug: 193185229 Test: Treehugger Change-Id: Ie4e59834a6dd23d83f30f8d0aaa1bf6d124ade91 Signed-off-by: DennySPb <[email protected]>
`android::util::Utf16ToUtf8()` actually returns a `std::string` due to the actual conversion to Utf8. `ParseResourceNamedType()` operates on a `StringPiece` of `converted` (the `std::string` returned from that call), and stashes it away for later use. Of course, by the time we're using the `StringPiece` in `parsed_type`, `converted` has already gone out of scope and is invalid to access. Bug: http://b/250827883 Test: ./art/test/testrunner/run_build_test_target.py -j80 art-asan Merged-In: Iea71a5cc84b7dfa96e7dcb549435f8394770a4df Change-Id: Ie03aa417c56df5cedd58bf0b32994d6b4e5395b4 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Lint is being updated, and a type that used to be non-null is now nullable, and needs to be null checked. Bug: 247885568 Test: Presubmits Change-Id: I7fc09a9d2d312485071364279c448550e3a1e124 Merged-In: Ie6eaf061d74bd773742aa47f731e95e4b137f438 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Test: m Fixes: 139342589 Change-Id: Ie4791425a4fcdf551ffa70b2c02ab3ed13e57eaa Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Add null pointer check to avoid system crash. Meet the below crash log during some app operations then app exits. F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x78 F DEBUG : Cause: null pointer dereference F DEBUG : backtrace: F DEBUG : #00 pc 0000000000323858 /system/lib64/libhwui.so (android::uirenderer::DeferredLayerUpdater::apply()+40) F DEBUG : syberia-project#1 pc 0000000000323040 /system/lib64/libhwui.so (_ZNSt3__110__function6__funcIZN7android10uirenderer12renderthread13 DrawFrameTask11postAndWaitEvE3$_0NS_9allocatorIS6_EEFvvEEclEv$c1671e 787f244890c877724752face20+416) Bug: b/243310920 Signed-off-by: Jessie Hao <[email protected]> Change-Id: I77226be2bd235852675bb4f7a29589e360269b33 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
In newer releases of the protobuf library, the release_* methods are marked [[nodiscard]], which causes a compilation error here. Bug: 203713560 Test: presubmit Change-Id: I44a9d52730bdc199e34cb25be959a955fff8f128 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
The former is a hidden API, the latter isn't. Bug: 244264995 Test: build ok Change-Id: Ie68aa00452cec96339c016634515593820243896 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
They're already triggered by some other dependency for "full" builds, but checkapi is expected to check all the APIs. Test: m checkapi (with breaking change) Change-Id: Ib9378bd6b6c43c7166309901f516c22e25e9ff4a Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Bug: 247056506 Test: manual Change-Id: I6f4b0c160f874d66169d7c4c6169bae7769a3e17 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Fix: 251257818 Test: lunch aosp_cf_x86_64_phone-userdebug Test: acloud create Test: atest SuspendPackageHelperTest Change-Id: I9a53541e98c0ba596b288ae92fe75f3279aac9cb Merged-In: Ie900be9e8f8a306f06e9856a25965c7a9e08b684 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
…oadcast MTS test. Grant FULL_ACCESS_CELL_BROADCAST_HISTORY permissions to the shell identity for use within CellBroadcast MTS tests. Bug: 236217191 Bug: 227422973 Test: atest com.android.cellbroadcastreceiver.compliancetests.CellBroadcastConfigTest Change-Id: Ief5a4c168968b4dc8c9cf7cc071618d41c23d220 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Bug: 240322840 Test: unit test Change-Id: Ia605ad8ad0267b02d67da15cf65775f69aef59e5 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
…onController Sometimes mPendingAnimations.remove will be called more than once in one cycle (line 255 - 270) of onAnimationFinished, e.g., mPendingAnimations.remove being called again in adapters.mAdapter.mCapturedFinishCallback.onAnimationFinished, resulting in IndexOutOfBoundsException. Bug:237989368 Change-Id: Ica771f1ae4cb4ddddb7684bd964504ca9f31ea12 Test: Monkey test str: rfp: merged on master CR: https://android-review.googlesource.com/c/platform/frameworks/base/+/2132452 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]> Change-Id: I129dfd2c89f795b8cd3d1eb723ab0fe067328b45 Signed-off-by: DennySPb <[email protected]>
Constructors for boxed primitives (Byte, Short, Integer, etc) have long been deprecated. The preferred pattern is to use valueOf(). d8 fails to convert these instances in TypedProperties, most likely due to the method complexity. Bug: N/A Test: Treehugger Change-Id: Ib58ecc853e2bd1e5d53e9ec256ef0467aa051d9f Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
When the program is run to unlockCanvasAndPost method, if mSurface.unlockCanvasAndPost throws an exception, the mSurfaceLock.unlock() will not getting the chance to execute. If an app executes unlockCanvasAndPost in a catch and does not handle the exception, it will remain locked for a long time after the next execution of mSurfacelock.lock. make sure the msurfacelock.unlock is executed after unlockCanvasAndPost bug:245050059 in partnerissuetracker Change-Id: Ib849c840c61ac261cfaab0daefa7ae2afdbfcba3 Signed-off-by: xiaoxin <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Bug: 243480218 Change-Id: I5a92ab2c6fb7b1286cda6eeada5cb042c882542e Test: manual Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Emptyness of a String8 variable was not checked correctly. As a result, even when no arguments were provided, `app_process` was still launching runtime. Test: adb shell app_process64 Change-Id: Ia303edb5a74b61efad24b475008a3642a07ab789 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
After upgrading libc++, there are errors complaining about the the
incomplete Clip type in the "std::vector<Clip> mClipStack" member of
SkiaCanvas. The "SkiaCanvas::SkiaCanvas() {}" ctor can call ~vector
(maybe when an exception is thrown), and ~vector needs to know the size
of Clip.
(I'm not sure why this wasn't a problem before, but this seems to fix
the problem.)
Bug: http://b/175635923
Test: treehugger
Change-Id: I1d689c91be3b0530272836eeb727709ff1084545
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: DennySPb <[email protected]>
As only the FGS flag is removed by removeForegroundServiceFlagFromNotification, it exceeds the package limit(MAX_PACKAGE_NOTIFICATIONS). And eventually OutOfMemory occurs and the device is reset. When the flag is removed, check in the same way the normal notification to prevent problems. Test: Searching for images in the Chrome browser Test: Download more than 50 images Test: Check NotificationRecord count in Notification dump Change-Id: Iacbc3a3e545f62d15bae5245ebcf6ed47f5c83a8 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
This value needs to be explicitly set to false to prevent re-using a stale "true" value. Fixes: 245965753 Test: CTS SensorHeadTrackerTest#testDiscontinuity (pending upload) Change-Id: Icd018e0cab9e30b0677970760a38a390d9dd2a3c Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
It will cause NullPointerException if the system app set the wallpaper before the third-party app set the wallpaper. Change-Id: I7e68cf3f89b690c7b114fa087d1fd1203d8eb4d6 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
If an app with a uid of Process.SYSTEM_UID calls view.startDragAndDrop, IllegalStateException will be thrown in Session.performDrag, which makes the drag-and-drop feature unavailable in this app. And we don't need this check either, because validateAndResolveDragMimeTypeExtras and validateDragFlags are indeed called before Binder.clearCallingIdentity. Bug: 245626682 Change-Id: I1c27287e51a956284dae0f61bfa0cac14dd28a27 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Avoids unnecessary allocations. Bug: N/A Test: Treehugger Change-Id: I4f1c9753decbb5da605a150a5bb878e565d1ba96 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
The overhead of checking all strings and having so much additional code take up space and run is not worth the potential performance improvement gained through direct instantiation. Signed-off-by: minaripenguin <[email protected]> Signed-off-by: DennySPb <[email protected]> Change-Id: Id2384960032d30b55f2392da9c540aad820dd5bb Signed-off-by: DennySPb <[email protected]>
…d() is called. Otherwise SysUI will crash. Tested with "Network traffic indicator". 01-07 22:27:19.805 3347 3347 E AndroidRuntime: FATAL EXCEPTION: main 01-07 22:27:19.805 3347 3347 E AndroidRuntime: Process: com.android.systemui, PID: 3347 01-07 22:27:19.805 3347 3347 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.ImageView.setLayoutParams(android.view.ViewGroup$LayoutParams)' on a null object reference 01-07 22:27:19.805 3347 3347 E AndroidRuntime: at com.android.systemui.BatteryMeterView.scaleBatteryMeterViews(BatteryMeterView.java:497) 01-07 22:27:19.805 3347 3347 E AndroidRuntime: at com.android.systemui.BatteryMeterView.onDensityOrFontScaleChanged(BatteryMeterView.java:437) Signed-off-by: spezi77 <[email protected]> Change-Id: Ic9378d1177a3ab8e80e1e6d6c9a064b4d626a3e2 Signed-off-by: DennySPb <[email protected]>
…ptions Change-Id: I9402a9668c046f29024793d473aed90b74a008a3 Signed-off-by: DennySPb <[email protected]>
Change-Id: I96eec1e945b59b3d19eefe70b133ec286439c382 Signed-off-by: DennySPb <[email protected]>
On desktop Linux, subpixel text positioning is necessary to avoid kerning issues, and Android is no different. Even though most phone displays have relatively high DPIs, the lack of subpixel text positioning is only unnoticeable on high-end devices such as the Pixel 4 XL (1440x3040 @ 6.3 in => 537 dpi). For example, on the Pixel 5 (1080 x 2340 @ 6.0 in => 432 dpi), horizontally-scrolling labels in QS tiles can be seen "jittering" slightly upon close observation. This was tested with the Google Sans font on Google's stock OS. At this lower DPI, there is still a need for subpixel text positioning (at least in some cases). Enable subpixel text positioning by default to fix occasional kerning issues and jittering when text is in motion. Change-Id: I8d71e5848a745c5a2d457a28c68458920928ee09 Signed-off-by: DennySPb <[email protected]>
This change makes sharesheet way more useful by increasing the amount of visible ranked apps. Change-Id: Ic092f1d1784259c9f3c0870eda1dd1ae8544c697 Signed-off-by: DennySPb <[email protected]>
Dark theme "TURN ON UNTIL SUNRISE"/MODE_NIGHT_AUTO is not kept after reboot. The reason is that TwilightState will takes time to update so lastState will be null in updateConfigurationLocked(). This lead to a reset of mComputedNightMode and mOverrideNightModeOn. This is a special bug for "TURN ON UNTIL SUNRISE"/MODE_NIGHT_AUTO, the other ones work fine and should not be touched, if we do not treat this as a special case we break the other ones. Test: Select "TURN ON UNTIL SUNRISE" in Dark Theme and reboot. Bug: 229228293 Change-Id: Ie32a6ddbbf03fa43ee6dd5e35b3c35ec03e58e0e Signed-off-by: DennySPb <[email protected]>
Multi-threaded operations cause data to be out of sync, resulting in null pointers. Add synchronization locks to ensure the uniqueness of data. Bug: 255494738 Test: manually test Change-Id: Ibae781258c688b3cb3f9b6bf69efe8fb5fbb2417 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Wifi screen cast connected equipment A and reboot device,wifi screen cast will not start wifi display scan,because MdiaRouter call back has selected equipment A ,and this time MediaRouter sStatic.mSelectedRoute will return A. Bug: 243324583 Test: manually Change-Id: I4da0f41feae29c871dc26b83b68786b322befb99 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
…tombstones separately. Bug: 255249203 Test: atest ErrorsTest Change-Id: I258657233ed643615cdd4b7ebdcf6447b1a964af Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Adapt interface getStateCount. Use int32. Bug: 243120067 Test: Manual Change-Id: Ibc892b38b8dcf15f9e65390c2d052700b6847672 Signed-off-by: DennySPb <[email protected]>
And also don't mess with power to reject call Signed-off-by: DennySPb <[email protected]>
What happens is that the dialer looses focus and stops the ringer / vibration Listen to calls and never display when we are in one Signed-off-by: DennySPb <[email protected]>
This reverts commit 91e7522. Temporary revert. No devices support this as of yet. Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
This is a new GLSL ripple animation inspired by Microsoft's Fluent Design, with an emphasis on responsiveness. The first frame of the animation includes a solid base highlight and a visible portion of the ripple circle, together serving as immediate feedback on finger up (especially in cases where few additional frames can be rendered, e.g. opening activities/fragment and dismissing dialogs). After the initial frame, the animation consists of a blurred circle that gradually expands (increasing radius), becomes less blurred, and finally fades out at the end of the animation. The animation timing follows a sine-based ease out curve, which is a decent balance between the animation feeling too fast and too slow/unnatural. Demo video: https://twitter.com/kdrag0n/status/1445806323535269893 Change-Id: I27192bd406490c39487dc84941f2f5c4a0fb33fe Signed-off-by: Adithya R <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Bug:260925085 Signed-off-by: linkai <[email protected]> Change-Id: I5a233b8ba5b207f06b2b639317b835a1e6a421d3 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
…ish Provider successfully,we need add pr.installProvider before scheduleInstallProvider Analysis: 1.when user is locked, start process will call generateApplicationProvidersLocked,if provider does not configure directBootAware, queryContentProviders cannot query this provider,mPubProviders cannot add this provider. 2.when user is unlocked, it will install provider, attachinfo will call Provider.onCreate,but it cannot publish successfully because mPubProviders not included it. 3.when other app access this provider, it will install provider again, and call Provider.onCreate again 4.If start thread to backup database file in Provider.onCreate. Calling onCreate twice will cause two threads to operate the same file, it will appear NE crash Bug: 262058328 Test: Set the lock screen password,reboot,unlock device and open the Contacts app Change-Id: I6e18a0de72ea0eb4052c5e4ffa178d14aba5df24 Signed-off-by: xieliangzhuo <[email protected]> Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Change-Id: I909b421fc22e8c35883d38f1a70f63085a229b49 Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
Play Protect was broken (uncertified device) on Realme X3. Reported to be broken on few other devices too, in other ROMs using PropImitationHooks. What's the point of having a clean implementation if it doesn't fucking work? Imported PPU from PE 13. Full history: https://github.com/PixelExperience/frameworks_base/commits/8a940b5453ffd5adc9775f60b4b9b69662fe8e0d/core/java/com/android/internal/util/custom/PixelPropsUtils.java Massively cleaned up code. As an added bonus, we also get the new Material You UI for the GMS bits in setup wizard. Co-authored-by: jhenrique09 <[email protected]> Co-authored-by: Pranav Vashi <[email protected]> Co-authored-by: Danny Lin <[email protected]> Signed-off-by: Adithya R <[email protected]> Signed-off-by: DennySPb <[email protected]> Change-Id: I844de94f098f7895dde4bc9c17e6ea7aff95187d
11-04 08:48:39.039 11637 11637 E AndroidRuntime: FATAL EXCEPTION: main
11-04 08:48:39.039 11637 11637 E AndroidRuntime: Process: com.NextFloor.DestinyChild, PID: 11637
11-04 08:48:39.039 11637 11637 E AndroidRuntime: java.lang.RuntimeException: Unable to get provider androidx.startup.InitializationProvider: androidx.startup.StartupException: android.content.pm.PackageManager$NameNotFoundException: ComponentInfo{/androidx.startup.InitializationProvider}
11-04 08:48:39.039 11637 11637 E AndroidRuntime: at android.app.ActivityThread.installProvider(ActivityThread.java:7488)
Change-Id: Icb12f938fe0fca710f8f9d29182d0134ba3c63eb
Signed-off-by: Adithya R <[email protected]>
Signed-off-by: DennySPb <[email protected]>
Rewritten from scratch, with settings toggle Based on the following commits: commit e2ebc7e0d3e74bff76f1cdc56e958c1f07fd4c0b Author: rdkng1 <[email protected]> Date: Sat Dec 11 05:17:22 2021 +0000 PixelPropsUtils: Add GamesProps Based on PixelPropsUtils, GamesProps will spoof the device needed to unlock the FPS of the following games: * Free Fire - Spoof Asus ROG Phone 1 will unlock 90 FPS * COD Mobile - Spoof Xperia 5 || will unlock 120 FPS (only on multiplayer mode) * PUBG Mobile - Spoof OnePlus 8 Pro will unlock 90 FPS * Wild Rift - Spoof OnePlus 8 Pro will unlock 120 FPS * Cyber Hunter - Spoof OnePlus 8 Pro will unlock 90 FPS * Fortnite - Spoof OnePlus 8 Pro will unlock 90 FPS @ neobuddy89: Adapt GamesProps to existing PixelProps and update games list. commit ce68c443c392c9be6fd0591958db960a1f10f9e3 Author: Pranav Vashi <[email protected]> Date: Sat Mar 26 12:32:23 2022 +0530 PixelPropsUtils: Add game props for mobile legends commit e819f8fb14924c32abce93cccc14fd9ea69b032b Author: Joey Huab <[email protected]> Date: Mon Aug 15 18:23:48 2022 +0000 PixelPropsUtils: Update game props * Removed new state as multiple crash reports. commit 328b97baa8039e4b127585ac467846faf5f13cb9 Author: johnmart19 <[email protected]> Date: Mon Jul 11 01:37:47 2022 +0300 PixelPropsUtils: GameProps: Hide Apex Legends as Mi11 Change-Id: I80b0136ef75f61154011ed7831994ffe8b5f5c96 Co-authored-by: rdkng1 <[email protected]> Co-authored-by: Pranav Vashi <[email protected]> Co-authored-by: Joey Huab <[email protected]> Co-authored-by: johnmart19 <[email protected]> Signed-off-by: Adithya R <[email protected]> Signed-off-by: DennySPb <[email protected]>
* O(1) lookup time Signed-off-by: jhonboy121 <[email protected]> Signed-off-by: Adithya R <[email protected]> Signed-off-by: DennySPb <[email protected]>
Signed-off-by: jhonboy121 <[email protected]> Signed-off-by: DennySPb <[email protected]>
Currently it force reloads theme on UI mode change always for black theme to set correctly, But this has the side effect of janky transition between dark<->light mode and other glitches in QS. Perform this only if we have black theme actually enabled. Change-Id: I372bdb51dacc54305d47cd42a5b165ac35609bd8 Signed-off-by: DennySPb <[email protected]>
Inspired by ArrowOS/android_frameworks_base@600674f Signed-off-by: DennySPb <[email protected]>
Signed-off-by: DennySPb <[email protected]> Change-Id: I5a1b944b362ecbd38dfbdb8a7589de539f83762d
Problem: {
1. Switch to guest user or any other user.
2. Open any Settings and any other app in split
3. Switch any language in the settings
3. Try to dismiss split. Crash will happen in system
}
Solution: {
1. Fixing AOSP logic to make application with uid equals to system in multi-user scenario.
2. So as a result mIsActivityConfigOverrideAllowed is false.
3. So Process's configuration is not changed which will eventually does not effect whole configuration.
}
Bug: 262486679
Change-Id: I8f078f41ca0fd4dbde71407efe395c7376b337d8
Signed-off-by: pioush.kumar-IN009423 <[email protected]>
The global keep rule for native methods allows stripping of such methods if they're unreferenced in Java. However, because system_server explicitly registers these methods from native code, stripping them in Java can cause runtime issues. As such, conservatively keep all such methods in system_server subpackages as long as the containing class is also kept or referenced. In practice, the difference is minimal, but this makes it easier to integrate optional debug pathways that have JNI interop. Bug: 246800015 Test: m services + inspect delta in services.jar Change-Id: Id1f9ab707edff9b1911cdde6bdd4bc24ebff7e49
make task change listener syncronized to avoid of concurency calls Change-Id: I2590886eec4a47c8dbc82fccc431bb1e212a04ea Signed-off-by: DennySPb <[email protected]>
… be cast to com.android.systemui.statusbar.StatusBarMobileView Inspired by yaap/frameworks_base@0459f5d nitrogen-project/android_frameworks_base@f00edd7 Change-Id: I3750f2dd252bb3764935e9fb025655ded4b447b3 Signed-off-by: DennySPb <[email protected]>
This prevents submitting tasks after the threadloop has been shutdown. Change-Id: Id899ddc9476d045c78c4e85bfac7e7a9b29cee6d Signed-off-by: DennySPb <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: DennySPb <[email protected]>
If a service is not present and an exeception is thrown in the SystemServiceRegistry, we log a message and proceed with the null service. Optional feature services, like app widgets, are expected to be missing if not supported. Properly handle the lookup, so no exception that pollutes the logs is emitted for what is normal operation. Test: No exception logged with the app widgets feature disabled Upstream from Meta Change-Id: I1cae4f9188ec47b55d68d7c8208f0da1c6c263b4 Signed-off-by: DennySPb <[email protected]>
pixel offset for display burn protection to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
95 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pixel offset for display burn protection to work properly.