Updated to work with Safari 11 no autoplay feature on video's - #46
Open
JoshEpic wants to merge 2 commits into
Open
Updated to work with Safari 11 no autoplay feature on video's #46JoshEpic wants to merge 2 commits into
JoshEpic wants to merge 2 commits into
Conversation
Added option to defaults to allow the ability to mute the video so it can be set to autoplay and will still work in Safari 11 update.
Updated muted option to default to true since autoplay is automatically true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the html5 video muted tag and added the ability to set it to true or false as an option. It defaults to true automatically.
Safari 11 introduced new features to no longer allow video's to autoplay on websites by default it doesn't autoplay anything with sound so by adding the muted tag it bypasses that flag and allows your BGVideo to play.