fix : escape HTML in contact API route email body - #22
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
HTML-encode name, email, subject, and message fields before inserting them into the HTML email body to prevent email header injection and XSS via crafted form input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done:
Added an escapeHtml() helper that encodes &, <, >, ", and ' as HTML entities. Applied it to the name, email, subject, and message fields before inserting them into the HTML email body. The plain-text version continues to use raw values. The message field still gets newlines converted to
after HTML escaping.
Changes Made:
Impact it Made:
Prevents email header injection (via subject/from fields) and XSS in mail clients that render HTML. Lint remains green.