[IMP] payment_ceca: precommit auto fixes

Author: Tisho99

payment_ceca/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Ceca Payment Acquirer",
     "version": "15.0.1.0.0",
     "category": "Payment",
-    "website": "https://www.sygel.es",
+    "website": "https://github.com/sygel-technology/sy-l10n-spain",
     "author": "Sygel, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "depends": [
@@ -16,7 +16,7 @@
     "data": [
         "views/payment_ceca_templates.xml",
         "views/payment_acquirer_view.xml",
-        "data/payment_ceca_data.xml"
+        "data/payment_ceca_data.xml",
     ],
-    "installable": True
+    "installable": True,
 }

payment_ceca/controllers/main.py

@@ -1,38 +1,54 @@
 # Copyright 2022 Manuel Regidor <manuel.regidor@sygel.es>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
+import logging
+
 from odoo import http
 from odoo.http import request
 
-import logging
 _logger = logging.getLogger(__name__)
 
 
 class PaymentTransacionCecaController(http.Controller):
 
-    _return_url = '/payment/ceca/feedback'
-    _error_url = '/payment/ceca/error'
-    _transaction_answer_url = '/payment/ceca/notify'
+    _return_url = "/payment/ceca/feedback"
+    _error_url = "/payment/ceca/error"
+    _transaction_answer_url = "/payment/ceca/notify"
 
-    @http.route(_return_url, type='http', auth='public', methods=['GET'], website=True)
+    @http.route(_return_url, type="http", auth="public", methods=["GET"], website=True)
     def ceca_form_feedback(self, **post):
-        return request.redirect('/payment/status')
+        return request.redirect("/payment/status")
 
-    @http.route(_error_url, type='http', auth='public', methods=['GET'], website=True)
+    @http.route(_error_url, type="http", auth="public", methods=["GET"], website=True)
     def ceca_form_error(self, **post):
-        if post.get('transaction'):
-            _logger.info("Cancelling CECA Transaction {}.".format(post.get('transaction')))
-            transaction = request.env['payment.transaction'].sudo().search([
-                ('provider', '=', 'ceca'),
-                ('reference', '=', post.get('transaction')),
-                ('state', '=', 'draft'),
-            ], limit=1)
+        if post.get("transaction"):
+            _logger.info(
+                "Cancelling CECA Transaction {}.".format(post.get("transaction"))
+            )
+            transaction = (
+                request.env["payment.transaction"]
+                .sudo()
+                .search(
+                    [
+                        ("provider", "=", "ceca"),
+                        ("reference", "=", post.get("transaction")),
+                        ("state", "=", "draft"),
+                    ],
+                    limit=1,
+                )
+            )
             if transaction:
                 transaction._set_canceled()
-        return request.redirect('/payment/status')
-
-    @http.route(_transaction_answer_url, type='http', auth='public', methods=['POST'], csrf=False)
+        return request.redirect("/payment/status")
+
+    @http.route(
+        _transaction_answer_url,
+        type="http",
+        auth="public",
+        methods=["POST"],
+        csrf=False,
+    )
     def ceca_notify(self, **post):
         _logger.info("CECA Online Notification: {}".format(post))
-        request.env['payment.transaction']._handle_feedback_data('ceca', post)
-        return 'success'
+        request.env["payment.transaction"]._handle_feedback_data("ceca", post)
+        return "success"

payment_ceca/data/payment_ceca_data.xml

@@ -1,24 +1,28 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!-- Copyright 2022 Manuel Regidor <manuel.regidor@sygel.es>
 License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
 <odoo noupdate="1">
     <record id="payment_acquirer_ceca" model="payment.acquirer">
         <field name="name">Ceca</field>
         <field name="provider">ceca</field>
-        <field name="image_128" type="base64" file="payment_ceca/static/src/img/ceca_icon.png"/>
+        <field
+            name="image_128"
+            type="base64"
+            file="payment_ceca/static/src/img/ceca_icon.png"
+        />
         <field name="description" type="html">
             <p>
                 CECA Virtual TPV.
-            </p>        
+            </p>
         </field>
-        <field name="redirect_form_view_id" ref="ceca_acquirer_button"/>
+        <field name="redirect_form_view_id" ref="ceca_acquirer_button" />
         <field name="ceca_acquirer_bin">XXXXXXXXXX</field>
         <field name="ceca_merchant_id">XXXXXXXXXX</field>
         <field name="ceca_terminal_id">XXXXXXXXXX</field>
         <field name="ceca_business_name">XXXXX</field>
         <field name="ceca_encriptation_key">XXXXXXXX</field>
         <field name="ceca_exponente">0</field>
-        <field name="ceca_tipo_moneda">0</field>        
+        <field name="ceca_tipo_moneda">0</field>
     </record>
     <record id="payment_method_ceca" model="account.payment.method">
         <field name="name">Ceca</field>

payment_ceca/models/account_payment_method.py

@@ -1,11 +1,11 @@
 # Copyright 2022 Manuel Regidor <manuel.regidor@sygel.es>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import models, api
+from odoo import api, models
 
 
 class AccountPaymentMethod(models.Model):
-    _inherit = 'account.payment.method'
+    _inherit = "account.payment.method"
 
     @api.model
     def _get_payment_method_information(self):

payment_ceca/models/payment_acquirer.py

@@ -3,116 +3,89 @@
 
 import hashlib
 
-from odoo import models, fields, api, _
-from odoo.addons.payment_ceca.controllers.main import PaymentTransacionCecaController
+from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
 
+from odoo.addons.payment_ceca.controllers.main import PaymentTransacionCecaController
+
 
 class PaymentAcquirer(models.Model):
-    _inherit = 'payment.acquirer'
+    _inherit = "payment.acquirer"
 
     def _get_ceca_url(self, env):
-        if env == 'prod':
-            return 'https://pgw.ceca.es/tpvweb/tpv/compra.action'
+        if env == "prod":
+            return "https://pgw.ceca.es/tpvweb/tpv/compra.action"
         else:
-            return 'https://tpv.ceca.es/tpvweb/tpv/compra.action'
+            return "https://tpv.ceca.es/tpvweb/tpv/compra.action"
 
     provider = fields.Selection(
-        selection_add=[('ceca', 'Ceca')],
-        ondelete={'ceca': 'set default'}
+        selection_add=[("ceca", "Ceca")], ondelete={"ceca": "set default"}
     )
     ceca_acquirer_bin = fields.Char(
-        string='Ceca Acquirer Bin',
-        required_if_provider='ceca'
+        string="Ceca Acquirer Bin", required_if_provider="ceca"
     )
     ceca_merchant_id = fields.Char(
-        string='Ceca Merchant Id',
-        required_if_provider='ceca'
+        string="Ceca Merchant Id", required_if_provider="ceca"
     )
     ceca_terminal_id = fields.Char(
-        string='Ceca Terminal Id',
-        required_if_provider='ceca'
+        string="Ceca Terminal Id", required_if_provider="ceca"
     )
     ceca_business_name = fields.Char(
-        string='Ceca Business Name',
-        required_if_provider='ceca'
+        string="Ceca Business Name", required_if_provider="ceca"
     )
     ceca_encriptation_key = fields.Char(
-        string='Ceca Encriptation Key',
-        required_if_provider='ceca'
-    )
-    ceca_exponente = fields.Char(
-        string='Ceca Exponente',
-        required_if_provider='ceca'
+        string="Ceca Encriptation Key", required_if_provider="ceca"
     )
+    ceca_exponente = fields.Char(string="Ceca Exponente", required_if_provider="ceca")
     ceca_tipo_moneda = fields.Char(
-        string='Ceca Tipo Moneda',
-        required_if_provider='ceca'
-    )
-    ceca_force_bizum = fields.Boolean(
-        string="Force Bizum"
+        string="Ceca Tipo Moneda", required_if_provider="ceca"
     )
-    ceca_force_card = fields.Boolean(
-        string="Force Card"
-    )
-    ceca_force_google = fields.Boolean(
-        string="Force Google Pay"
-    )
-    ceca_force_apple = fields.Boolean(
-        string="Force Apple Pay"
-    )   
+    ceca_force_bizum = fields.Boolean(string="Force Bizum")
+    ceca_force_card = fields.Boolean(string="Force Card")
+    ceca_force_google = fields.Boolean(string="Force Google Pay")
+    ceca_force_apple = fields.Boolean(string="Force Apple Pay")
 
     @api.constrains(
-        "ceca_force_bizum",
-        "ceca_force_card",
-        "ceca_force_google",
-        "ceca_force_apple"
+        "ceca_force_bizum", "ceca_force_card", "ceca_force_google", "ceca_force_apple"
     )
     def _check_unique_force_method(self):
         for sel in self:
-            if sel.provider == 'ceca' and [
-                sel.ceca_force_bizum,
-                sel.ceca_force_card,
-                sel.ceca_force_google,
-                sel.ceca_force_apple
-            ].count(True) > 1:
-                raise ValidationError(
-                    _(
-                        "Only one payment mode can be forced."
-                    )
-                )                
+            if (
+                sel.provider == "ceca"
+                and [
+                    sel.ceca_force_bizum,
+                    sel.ceca_force_card,
+                    sel.ceca_force_google,
+                    sel.ceca_force_apple,
+                ].count(True)
+                > 1
+            ):
+                raise ValidationError(_("Only one payment mode can be forced."))
 
     def ceca_values(self, values):
 
-        base_url = self.env['ir.config_parameter'].get_param('web.base.url')
+        base_url = self.env["ir.config_parameter"].get_param("web.base.url")
 
-        api_url = self._get_ceca_url(
-            "prod" if self.state == "enabled" else "test"
-        )
+        api_url = self._get_ceca_url("prod" if self.state == "enabled" else "test")
         MerchantID = self.ceca_merchant_id
         AcquirerBIN = self.ceca_acquirer_bin
         TerminalID = self.ceca_terminal_id
         Exponente = self.ceca_exponente
         TipoMoneda = self.ceca_tipo_moneda
-        URL_OK = "{}{}".format(
-            base_url,
-            PaymentTransacionCecaController._return_url
-        )
+        URL_OK = "{}{}".format(base_url, PaymentTransacionCecaController._return_url)
         URL_NOK = "{}{}?transaction={}".format(
-            base_url,
-            PaymentTransacionCecaController._error_url,
-            values['reference']
+            base_url, PaymentTransacionCecaController._error_url, values["reference"]
         )
-        Num_operacion = values['reference']
+        Num_operacion = values["reference"]
         # REVISAR ESTO COPIADO DEL OTRO MÓDULO
-        amount_split = str(values['amount']).split('.')
-        Importe = str(amount_split[0])+str(amount_split[1])
+        amount_split = str(values["amount"]).split(".")
+        Importe = str(amount_split[0]) + str(amount_split[1])
         # Fix ad 0 final
         if len(amount_split[1]) == 1:
-            Importe = str(Importe)+'0'        
+            Importe = str(Importe) + "0"
         Idioma = 1
-        Pago_soportado = 'SSL'
-        Cifrado = 'SHA2'
+        Pago_soportado = "SSL"
+        Cifrado = "SHA2"
         Clave = self.ceca_encriptation_key
         Firma = "{}{}{}{}{}{}{}{}{}{}{}".format(
             Clave,
@@ -125,46 +98,40 @@ def ceca_values(self, values):
             Exponente,
             Cifrado,
             URL_OK,
-            URL_NOK
+            URL_NOK,
         )
         Firma = hashlib.sha256(Firma.encode()).hexdigest()
-        values.update({
-            'api_url': api_url,
-            'MerchantID': MerchantID,
-            'AcquirerBIN': AcquirerBIN,
-            'TerminalID': TerminalID,
-            'Exponente': Exponente,
-            'TipoMoneda': TipoMoneda,
-            'URL_OK': URL_OK,
-            'URL_NOK': URL_NOK,
-            'Num_operacion': Num_operacion,
-            'Importe': Importe,
-            'Idioma': Idioma,
-            'Pago_soportado': Pago_soportado,
-            'Descripcion': values['reference'],
-            'Firma': Firma,
-            'Cifrado': Cifrado
-        })
+        values.update(
+            {
+                "api_url": api_url,
+                "MerchantID": MerchantID,
+                "AcquirerBIN": AcquirerBIN,
+                "TerminalID": TerminalID,
+                "Exponente": Exponente,
+                "TipoMoneda": TipoMoneda,
+                "URL_OK": URL_OK,
+                "URL_NOK": URL_NOK,
+                "Num_operacion": Num_operacion,
+                "Importe": Importe,
+                "Idioma": Idioma,
+                "Pago_soportado": Pago_soportado,
+                "Descripcion": values["reference"],
+                "Firma": Firma,
+                "Cifrado": Cifrado,
+            }
+        )
         if self.ceca_force_card:
-            values.update({
-                'inicioTarjeta': "1"
-            })
+            values.update({"inicioTarjeta": "1"})
         elif self.ceca_force_bizum:
-            values.update({
-                'inicioBizum': "1"
-            })
+            values.update({"inicioBizum": "1"})
         elif self.ceca_force_google:
-            values.update({
-                'inicioGoogle': "1"
-            })
+            values.update({"inicioGoogle": "1"})
         elif self.ceca_force_apple:
-            values.update({
-                'inicioApple': "1"
-            })        
+            values.update({"inicioApple": "1"})
         return values
 
     def _get_default_payment_method_id(self):
         self.ensure_one()
-        if self.provider != 'ceca':
+        if self.provider != "ceca":
             return super()._get_default_payment_method_id()
-        return self.env.ref('payment_ceca.payment_method_ceca').id
+        return self.env.ref("payment_ceca.payment_method_ceca").id