Skip to content

[T-9053][15.0][ADD] payment_ceca#14

Merged
Sygel-bot merged 1 commit into15.0from
15.0-T-9053
Feb 2, 2026
Merged

[T-9053][15.0][ADD] payment_ceca#14
Sygel-bot merged 1 commit into15.0from
15.0-T-9053

Conversation

@Tisho99
Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 commented Jan 26, 2026

No description provided.

@Tisho99 Tisho99 force-pushed the 15.0-T-9053 branch 3 times, most recently from b8c68d0 to 1a62104 Compare January 27, 2026 12:38
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 43.79562% with 77 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
payment_ceca/models/payment_acquirer.py 36.50% 40 Missing ⚠️
payment_ceca/models/payment_transaction.py 25.00% 27 Missing ⚠️
payment_ceca/controllers/main.py 58.33% 10 Missing ⚠️
Files with missing lines Coverage Δ
payment_ceca/__init__.py 100.00% <100.00%> (ø)
payment_ceca/controllers/__init__.py 100.00% <100.00%> (ø)
payment_ceca/models/__init__.py 100.00% <100.00%> (ø)
payment_ceca/models/account_payment_method.py 100.00% <100.00%> (ø)
payment_ceca/controllers/main.py 58.33% <58.33%> (ø)
payment_ceca/models/payment_transaction.py 25.00% <25.00%> (ø)
payment_ceca/models/payment_acquirer.py 36.50% <36.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tisho99 Tisho99 force-pushed the 15.0-T-9053 branch 3 times, most recently from 0a73a31 to 35635e4 Compare January 29, 2026 10:58
Copy link
Copy Markdown

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ValentinVinagre
Copy link
Copy Markdown
Contributor

/sygelbot merge nobump

@Sygel-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-14-by-ValentinVinagre-bump-nobump, awaiting test results.

Sygel-bot added a commit that referenced this pull request Jan 29, 2026
Signed-off-by ValentinVinagre
@Sygel-bot
Copy link
Copy Markdown
Contributor

@ValentinVinagre The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_l10n_es_facturae_custom_rounding-15.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_l10n_es_facturae_custom_rounding-15.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         This filename was previously used by a file that has since been        
         deleted. Use a different version. See                                  
         https://pypi.org/help/#file-name-reuse for more information.           

@manuel-florido
Copy link
Copy Markdown
Contributor

@Tisho99 @ValentinVinagre

This error comes from PyPI, not from the bot.

PyPI does not allow reusing the same filename (package name + version + tags), even if the file or the whole release was deleted in the past. Once a file with a given version has been uploaded and later removed, that exact filename is permanently blocked.

In this case, the wheel odoo_addon_l10n_es_facturae_custom_rounding-15.0.1.0.0.2-...whl was already uploaded before and then deleted, so PyPI returns an error message.

Solution:
You can try bumping the addon version (e.g. 15.0.1.0.0.3) and publish again.

Even after bumping the addon version, it is still possible to hit the same PyPI error.

@ValentinVinagre
Copy link
Copy Markdown
Contributor

@Tisho99 puedes indicar la versión "15.0.1.0.3"?

@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Jan 29, 2026

@ValentinVinagre

Hecho.

Como nota, la version subida es la del módulo l10n_es_facturae_custom_rounding, que es el que parece estar fallando según el error, y no es el módulo principal de este PR. Si sigue habiendo problemas propondría separar este PR en 2.

@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Feb 2, 2026

@ValentinVinagre Hice lo que pediste, subir la versión a "15.0.1.0.3". ¿Podrías intentar mergear?

@ValentinVinagre
Copy link
Copy Markdown
Contributor

@Tisho99 separa en 2 pr's ya que son 2 módulos diferentes, merci.

@ValentinVinagre
Copy link
Copy Markdown
Contributor

@Tisho99 pre-commit 😄

@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Feb 2, 2026

@ValentinVinagre Ya esta, era hacer un rebase porque el precommit lo arreglaba el commit que he separado en el otro PR

Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ValentinVinagre
Copy link
Copy Markdown
Contributor

/sygelbot merge nobump

@Sygel-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-14-by-ValentinVinagre-bump-nobump, awaiting test results.

@Sygel-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0acb9d7. Thanks a lot for contributing to sygel-technology. ❤️

@Sygel-bot Sygel-bot merged commit 9b7c552 into 15.0 Feb 2, 2026
4 of 5 checks passed
@Sygel-bot Sygel-bot deleted the 15.0-T-9053 branch February 2, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants