Conversation
Tisho99
changed the title
Tisho99
force-pushed
the
17.0-T-8373
branch
2 times, most recently
from
b49f7b3 to
accfb18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Jaimermaccione
left a comment
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Tisho99 Hi Alberto,
I'm currently reviewing the module from a functional perspective. Would it be possible to also display the reference when viewing the subcontacts under the parent contact?
The point is, sometimes the parent is reviewed to look into a specific member (subcontact), especially since they also have the OCA module that allows opening the contact directly from that view.
Let me know. Thanks!
|
@Jaimermaccione It's possible, but that is a different customization. This module edits the display_name field, a computed field that is shown by the system in some places, however what is shown there is the normal name, another field If it's important, I recommend you to talk with Manu and define what to do, probably editing the custom |
Jaimermaccione
left a comment
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Tisho99 Understood, Alberto! From my side, the module is working well — functional review done in the local environment. LGTM!
|
|
||
| * ... | ||
|
|
||
| #. Go to a partner form of type company #. In the "Sales and Purchase" |
There was a problem hiding this comment.
This is not properly formatted.
|
@Tisho99 Alberto, Sorry I didn’t catch this earlier — I was running some tests and noticed that the modified references aren’t showing up in the list view. They do appear fine in the kanban view though.
Could you take a look? Thanks! |
…stead of the parent one
|
This case is the same as the children's kanban. The displayed field set by odoo is the name, not the computed one im editing in this module I can edit it in the custom to:
I am going to edit the custom MR with the option 1. Tell me if it is correct |
|
@Tisho99 Perfect, Alberto. Functionally reviewed in the custom MR and everything looks good. Thanks! |
manuelregidor
left a comment
manuelregidor
left a comment
There was a problem hiding this comment.
Technical review. LGTM
|
This PR has the |
|
@ValentinVinagre Can you review? |
There was a problem hiding this comment.
Blocked.
Please add a before and after photo of this change.
Has interaction with this module been considered?
https://github.com/OCA/partner-contact/tree/17.0/partner_firstname
|
|
||
| own_ref_in_name = fields.Boolean() | ||
|
|
||
| def _get_complete_name(self): |
There was a problem hiding this comment.
shouldn't there be a depends on the new field?
| class Partner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| own_ref_in_name = fields.Boolean() |
There was a problem hiding this comment.
Why by partner? Wouldn't this be a company or global configuration in the system?
There was a problem hiding this comment.
Do you know if the client requires all contacts to have their own contact ref in their name? Or do some have to have their parent's ref?
Basically, based on reading the description, I understand they must have their own ID. Do you know why the client specified which ref to display at the contact level?
There was a problem hiding this comment.
@Tisho99 The client only requires individual contact references for those contacts that are delivery addresses acting as cooperative members. For all other cases, the standard behavior should apply — meaning the contact should inherit the parent’s reference.
Does that help clarify?
|
The interaction with the partner_firstname hadn't been considered. However, I have reviewed the module and they are compatible because they edit distinct fields, and both does the inheritance correctly Can we continue with the task? |
|
Before: After: |
Of course, he has already paid his toll 😸 |
|
/sygelbot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 224df62. Thanks a lot for contributing to sygel-technology. ❤️ |
5 participants
No description provided.