Skip to content

[T-8592][18.0][MIG] partner_code_program_sale: migration to 18.0#51

Merged
Sygel-bot merged 4 commits into18.0from
18.0-T-8592-mig-partner_code_program_sale
Jun 30, 2025
Merged

[T-8592][18.0][MIG] partner_code_program_sale: migration to 18.0#51
Sygel-bot merged 4 commits into18.0from
18.0-T-8592-mig-partner_code_program_sale

Conversation

@Anxo82
Copy link
Copy Markdown
Contributor

@Anxo82 Anxo82 commented Jun 20, 2025

@HaraldPanten @Jaimermaccione

Copy link
Copy Markdown

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anxo82 Functional review on local environment. LGTM!

Comment thread partner_code_program_sale/readme/USAGE.md Outdated
Comment thread partner_code_program_sale/tests/test_partner_code_program_sale.py
@Anxo82 Anxo82 force-pushed the 18.0-T-8592-mig-partner_code_program_sale branch from 59130ab to c92e64b Compare June 26, 2025 08:43
@Anxo82
Copy link
Copy Markdown
Contributor Author

Anxo82 commented Jun 26, 2025

@Tisho99 changes done, could you review? Thanks

Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Comment in the description the PR dependences

@Anxo82
Copy link
Copy Markdown
Contributor Author

Anxo82 commented Jun 26, 2025

@ValentinVinagre technical and functional review OK, could you check and merge?
This module depends on partner_code_program (#46) which is pending.

@ValentinVinagre
Copy link
Copy Markdown

/sygelbot rebase

@Sygel-bot
Copy link
Copy Markdown
Contributor

Congratulations, PR rebased to 18.0.

@Sygel-bot Sygel-bot force-pushed the 18.0-T-8592-mig-partner_code_program_sale branch from c92e64b to 313f808 Compare June 30, 2025 10:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
partner_code_program_sale/__init__.py 100.00% <100.00%> (ø)
partner_code_program_sale/models/__init__.py 100.00% <100.00%> (ø)
partner_code_program_sale/models/sale_order.py 100.00% <100.00%> (ø)
partner_code_program_sale/models/sale_report.py 100.00% <100.00%> (ø)
partner_code_program_sale/tests/__init__.py 100.00% <100.00%> (ø)
...ogram_sale/tests/test_partner_code_program_sale.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValentinVinagre
Copy link
Copy Markdown

/sygelbot merge nobump

@Sygel-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-51-by-ValentinVinagre-bump-nobump, awaiting test results.

@Sygel-bot Sygel-bot merged commit 4b7d375 into 18.0 Jun 30, 2025
5 checks passed
@Sygel-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at faafc4b. Thanks a lot for contributing to sygel-technology. ❤️

@Sygel-bot Sygel-bot deleted the 18.0-T-8592-mig-partner_code_program_sale branch June 30, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants