[T-8768][18.0][MIG] contact_referred: Migration to v18.0#65
Conversation
…_contact_old_migration_fields,partner_vat_required:pre-commit auto fixes
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
ValentinVinagre
left a comment
There was a problem hiding this comment.
Please don't put T/I references in the commit, thanks.
3b597a2 to
0d36292
Compare
|
@ValentinVinagre changes done. Could you please review? Thanks. |
|
@Anxo82 why only 1 commit? and the pre-commit auto fixes ? |
2e043e5 to
942a9cb
Compare
There was a problem hiding this comment.
@Anxo82 The module has been functionally tested in a local environment.
The module performs as expected. It adds a new relational field to the Contact form that allows linking a contact to another existing contact as a referred contact.
Functional Validation
- A new field "Referred Contact" is added to the contact form.
- The field allows selecting another contact from the database.
- The field is correctly stored and displayed after saving.
- The field is also available in the Contacts list view as an optional column.
- The column is hidden by default but can be enabled using the column selector.
No functional issues were detected during testing.
The module behaves consistently with its intended purpose.
2. README Improvement Proposal
The current README is technically correct but lacks functional detail.
Below is a suggested improved version:
Contact Referred
This module allows linking a contact to another contact by defining a referred contact.
1. Installation
No special configuration is required.
2. Configuration
No additional configuration is required after installation.
3. Usage and Functionality
This module adds a new field to the Contact form to define a referred contact.
To use it:
- Go to the Contacts application.
- Open any contact record.
- Navigate to the Sales & Purchases tab at the bottom of the form.
- You will find a new field called Referred Contact.
- Select another contact from your database and save the record.
List View
The module also adds the Referred Contact column to the Contacts list view.
- The column is hidden by default.
- It can be enabled using the column selector on the right side of the list view.
3. Conclusion
After clarifying and improving the README for better accuracy, the module would be considered functionally correct from my side.
942a9cb to
ea09516
Compare
|
@Jaimermaccione changes done! Thanks. |
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Anxo82 Reviewed changes on README.
LGTM! Thank you!
|
/sygelbot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f36f35e. Thanks a lot for contributing to sygel-technology. ❤️ |
@ValentinVinagre