Skip to content

[T-8768][18.0][MIG] contact_referred: Migration to v18.0#65

Merged
Sygel-bot merged 6 commits into18.0from
18.0-T-8768-mig-contact_referred
Apr 2, 2026
Merged

[T-8768][18.0][MIG] contact_referred: Migration to v18.0#65
Sygel-bot merged 6 commits into18.0from
18.0-T-8768-mig-contact_referred

Conversation

@Anxo82
Copy link
Copy Markdown
Contributor

@Anxo82 Anxo82 commented Sep 5, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
contact_referred/__init__.py 100.00% <100.00%> (ø)
contact_referred/models/__init__.py 100.00% <100.00%> (ø)
contact_referred/models/res_partner.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@sara-castello sara-castello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

Copy link
Copy Markdown

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put T/I references in the commit, thanks.

Comment thread contact_referred/views/res_partner_views.xml
@Anxo82 Anxo82 force-pushed the 18.0-T-8768-mig-contact_referred branch from 3b597a2 to 0d36292 Compare September 8, 2025 08:08
@Anxo82
Copy link
Copy Markdown
Contributor Author

Anxo82 commented Sep 8, 2025

@ValentinVinagre changes done. Could you please review? Thanks.

@ValentinVinagre
Copy link
Copy Markdown

@Anxo82 why only 1 commit? and the pre-commit auto fixes ?

@Anxo82 Anxo82 force-pushed the 18.0-T-8768-mig-contact_referred branch 2 times, most recently from 2e043e5 to 942a9cb Compare January 21, 2026 15:58
Copy link
Copy Markdown

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anxo82 The module has been functionally tested in a local environment.

The module performs as expected. It adds a new relational field to the Contact form that allows linking a contact to another existing contact as a referred contact.

Functional Validation

  • A new field "Referred Contact" is added to the contact form.
  • The field allows selecting another contact from the database.
  • The field is correctly stored and displayed after saving.
  • The field is also available in the Contacts list view as an optional column.
  • The column is hidden by default but can be enabled using the column selector.

No functional issues were detected during testing.
The module behaves consistently with its intended purpose.


2. README Improvement Proposal

The current README is technically correct but lacks functional detail.
Below is a suggested improved version:


Contact Referred

This module allows linking a contact to another contact by defining a referred contact.

1. Installation

No special configuration is required.

2. Configuration

No additional configuration is required after installation.

3. Usage and Functionality

This module adds a new field to the Contact form to define a referred contact.

To use it:

  1. Go to the Contacts application.
  2. Open any contact record.
  3. Navigate to the Sales & Purchases tab at the bottom of the form.
  4. You will find a new field called Referred Contact.
  5. Select another contact from your database and save the record.
List View

The module also adds the Referred Contact column to the Contacts list view.

  • The column is hidden by default.
  • It can be enabled using the column selector on the right side of the list view.

3. Conclusion

After clarifying and improving the README for better accuracy, the module would be considered functionally correct from my side.

@Anxo82 Anxo82 force-pushed the 18.0-T-8768-mig-contact_referred branch from 942a9cb to ea09516 Compare April 2, 2026 07:45
@Anxo82
Copy link
Copy Markdown
Contributor Author

Anxo82 commented Apr 2, 2026

@Jaimermaccione changes done! Thanks.

Copy link
Copy Markdown

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anxo82 Reviewed changes on README.

LGTM! Thank you!

Copy link
Copy Markdown

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ValentinVinagre
Copy link
Copy Markdown

/sygelbot merge nobump

@Sygel-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-65-by-ValentinVinagre-bump-nobump, awaiting test results.

@Sygel-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f36f35e. Thanks a lot for contributing to sygel-technology. ❤️

@Sygel-bot Sygel-bot merged commit 9442605 into 18.0 Apr 2, 2026
5 checks passed
@Sygel-bot Sygel-bot deleted the 18.0-T-8768-mig-contact_referred branch April 2, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants