Conversation
Tisho99
force-pushed
the
18.0-mig-html_fields_document_layout_configuration
branch
from
fb5a41f to
d05ff12
Compare
Jaimermaccione
left a comment
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Tisho99 Functional review completed in a local environment.
The module was tested with developer mode enabled and behaves as described in the README: it allows editing the document layout HTML fields using the HTML widget.
LGTM!
Note: If this is already part of our usual practice, please check that the Sygel logo is included in the README, as I don’t see it currently.
|
The readme is automatically generated, I should't add the logo there What i have done is replacing the old logo by the new one in the static/description folder. That logo should be shown in the modules kanban view |
|
/sygelbot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
@Tisho99 @Jaimermaccione Please check that the logo has been modified correctly after merging, thanks. |
|
Congratulations, your PR was merged at d3248a2. Thanks a lot for contributing to sygel-technology. ❤️ |
Sygel-bot
deleted the
18.0-mig-html_fields_document_layout_configuration
branch
|
@Tisho99 @ValentinVinagre I’ve tested it after the merge by installing the module using the standard addons method (without copying it into the private addons folder). The logo is displayed correctly in the Kanban view, so if that is the expected check, everything looks fine. If the expectation was to also have the logo shown in the README, it does not appear there, but if that is not part of the verification, then it shouldn’t be an issue. Thanks both! |
5 participants
No description provided.