Skip to content

Conversation

bcc32
Copy link
Collaborator

@bcc32 bcc32 commented Mar 9, 2025

When using org-modern-mode:

  • Disable org-superstar from the spacemacs-org layer. These packages
    have overlapping functionality, and org-modern's README recommends
    not using org-superstar at the same time.

  • Use global-org-modern-mode directly rather than reimplementing it.
    This allows it to be easily disabled globally

  • Add a key binding to toggle global-org-modern-mode

bcc32 added 3 commits March 9, 2025 14:15
org-modern provides similar functionality for the leading stars in org
headlines and it is recommended to disable org-superstar when
org-modern is used.
;; `org' package.
(default-org-config :location built-in)
org-superstar
(org-superstar :toggle (not (configuration-layer/package-used-p 'org-modern)))
Copy link
Collaborator

@fnussbaum fnussbaum Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to depend on a solution for #16346 which is not implemented or pushed yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sad. It works on my branch because I have a WIP fix for #16346. Thanks for catching this. Making the PR into a draft for now.

@bcc32 bcc32 marked this pull request as draft March 12, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants