Add missing lexical binding cookies #16960
Merged
+611
−592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most files lexical-binding: t should also work without changes. But for each file, someone would need examine it and check whether dynamic binding is relied on somewhere. Hence I went with the current default of lexical-binding: nil for now to pacify the warnings in Emacs 31.
bcc32
approved these changes
Apr 22, 2025
Contributor
|
With this version, the only warning I'm now getting is from |
Collaborator
Consider reporting upstream? |
Collaborator
Author
@korayal Thanks for testing! Until this is fixed upstream, you could try something like the following in (advice-add
'company-statistics--load :around
(lambda (orig-fun)
(let ((warning-inhibit-types '((files missing-lexbind-cookie))))
(funcall orig-fun)))) |
Contributor
|
@fnussbaum that works perfectly, thanks! |
saintaardvark
added a commit
to saintaardvark/dot.emacs.d
that referenced
this pull request
Jun 15, 2025
I upgraded to the latest Emacs today, and saw warnings about the lack
of a lexical-binding cookie in these files. After a bit of reading,
it looks like lexical-binding is where Elisp is going and probably
harmless, so I've decied to enable it here.
Refs:
- https://lists.gnu.org/r/emacs-devel/2024-05/msg00250.html
- magit/magit#5361
- syl20bnr/spacemacs#16960
- https://www.emacswiki.org/emacs/DynamicBindingVsLexicalBinding
saintaardvark
added a commit
to saintaardvark/dot.emacs.d
that referenced
this pull request
Jun 24, 2025
I upgraded to the latest Emacs today, and saw warnings about the lack
of a lexical-binding cookie in these files. After a bit of reading,
it looks like lexical-binding is where Elisp is going and probably
harmless, so I've decied to enable it here.
Refs:
- https://lists.gnu.org/r/emacs-devel/2024-05/msg00250.html
- magit/magit#5361
- syl20bnr/spacemacs#16960
- https://www.emacswiki.org/emacs/DynamicBindingVsLexicalBinding
hydravigil
pushed a commit
to hydravigil/spacemacs
that referenced
this pull request
Jan 6, 2026
* Enable lexical binding for some files * Disable lexical binding for remaining files missing declaration For most files lexical-binding: t should also work without changes. But for each file, someone would need examine it and check whether dynamic binding is relied on somewhere. Hence I went with the current default of lexical-binding: nil for now to pacify the warnings in Emacs 31. * [core] Enable lexical binding in spacemacs/dump-vars-to-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16959.
For most files
lexical-binding: tshould also work without changes. But for each file, someone would need examine it and check whether dynamic binding is relied on somewhere. Hence I went with the current default oflexical-binding: nilfor most files for now to pacify the warnings in Emacs 31.