Skip to content

Conversation

@EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Mar 26, 2025

  • Bump golangci-lint to v2.1.x
  • Resolve issues discovered by same (incl. implementing build subcommand argument validation unit tests)

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 61.19403% with 26 lines in your changes missing coverage. Please review.

Project coverage is 48.66%. Comparing base (6d99a79) to head (ff001e0).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/buildclient/pgpSigner.go 0.00% 10 Missing ⚠️
internal/app/buildclient/build.go 78.12% 7 Missing ⚠️
internal/app/buildclient/artifact.go 0.00% 2 Missing ⚠️
internal/app/buildclient/client.go 77.77% 2 Missing ⚠️
internal/app/buildclient/files.go 71.42% 2 Missing ⚠️
client/build.go 0.00% 1 Missing ⚠️
client/output.go 80.00% 1 Missing ⚠️
internal/app/buildclient/sign.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   47.48%   48.66%   +1.17%     
==========================================
  Files          19       19              
  Lines        1312     1344      +32     
==========================================
+ Hits          623      654      +31     
- Misses        621      622       +1     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmmEff EmmEff force-pushed the update-ci branch 2 times, most recently from 93c4360 to 01cb74f Compare April 2, 2025 17:49
@EmmEff EmmEff marked this pull request as ready for review April 2, 2025 17:49
EmmEff added 2 commits April 21, 2025 10:03
Also includes lint fixes discovered by newer version of golangci-lint
@EmmEff EmmEff merged commit 1be0ed1 into sylabs:main Apr 28, 2025
3 checks passed
@EmmEff EmmEff deleted the update-ci branch June 20, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant