Skip to content

feat(investments): improve IBKR setup UX and fix stale price handling - #117

Open
kostaskracht wants to merge 1 commit into
mainfrom
kostas/investments-beta-testing
Open

feat(investments): improve IBKR setup UX and fix stale price handling#117
kostaskracht wants to merge 1 commit into
mainfrom
kostas/investments-beta-testing

Conversation

@kostaskracht

@kostaskracht kostaskracht commented May 6, 2026

Copy link
Copy Markdown
Collaborator
  • Add step-by-step Flex Query setup guide dialog to IBKR connection form
  • Fix price fetching to use most recent available price when today's price unavailable
  • Add SYLLOGIC_SECRET_KEY env var for broker credential encryption
  • Update CODEOWNERS documentation

Pull Request

Description

Please include a summary of the changes and the related issue.
Also include relevant motivation and context.

Fixes #(issue_number)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklist

  • My code follows the project’s style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests pass
  • I have checked my changes for sensitive data or secrets

Additional Context

Add any other context or screenshots about the PR here.


Summary by cubic

Adds a step-by-step IBKR Flex Query setup guide in the broker connection form and improves price valuation by falling back to the most recent available quote when today’s price is missing. Introduces SYLLOGIC_SECRET_KEY for encrypting broker credentials.

  • Bug Fixes

    • Price lookup now tries the requested date first; falls back to the latest stored snapshot if missing.
    • Marks prices as stale based on gap days and logs a warning when no price is available.
  • Migration

    • Set SYLLOGIC_SECRET_KEY in your environment to enable broker credential encryption (docker-compose updated for backend and worker).

Written for commit 5aecc0b. Summary will update on new commits.

- Add step-by-step Flex Query setup guide dialog to IBKR connection form
- Fix price fetching to use most recent available price when today's price unavailable
- Add SYLLOGIC_SECRET_KEY env var for broker credential encryption
- Update CODEOWNERS documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@kostaskracht
kostaskracht requested a review from a team as a code owner May 6, 2026 12:16
@vercel

vercel Bot commented May 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
syllogic Ready Ready Preview, Comment May 6, 2026 0:16am

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant