Skip to content

fix(razorback): parser can parse multiple tags + ignore EOI #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fisherjacobc
Copy link
Contributor

Currently, razorback can only parse one tag, since the parser is parsing the script as a Rule::value and not as Rule::script

This PR fixes this issue, allowing for every tag to be parsed

@fisherjacobc
Copy link
Contributor Author

I just noticed that it doesn't support outer nodes, will fix soon

@sylv
Copy link
Owner

sylv commented Feb 19, 2024

EOI I don't think should be in the result but it should be ignored in the parse_pair function. Here it's being parsed into a node only to be ignored which is kinda gross.
parse_pair might have to be changed to return Option<Node> so it can reply with None but thats kinda a pain in the ass

@fisherjacobc
Copy link
Contributor Author

Option<Node> is probably the best bet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants