Upgrade Go to 1.24.1 (from 1.23.6) and all Go packages#432
Merged
bauersimon merged 8 commits intomainfrom Mar 27, 2025
Merged
Conversation
zimmski
force-pushed
the
go-1.24.1
branch
2 times, most recently
from
14ee283 to
8a7d431
Compare
ahumenberger
force-pushed
the
go-1.24.1
branch
5 times, most recently
from
e631a7a to
503a81c
Compare
ahumenberger
force-pushed
the
go-1.24.1
branch
2 times, most recently
from
a631ced to
e4ace34
Compare
Member
Author
|
@ahumenberger i see this upgrade as a "bugfix" release so please after merging, let's create a release and add it to the discussion. Then upgrade internally in the symflower repo. |
Munsio
force-pushed
the
go-1.24.1
branch
6 times, most recently
from
01e73a3 to
29176fc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Go version to 1.24.1 and updates the auto-generated mocks across several packages by bumping mockery from v2.40.3 to v2.53.2. The changes also include adjustments to logger functions, modifications to expected test error messages, and updates in GitHub workflow configurations to derive the Go version from go.mod.
Reviewed Changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| provider/testing/*_mock_gen.go | Updated header comment to reflect mockery v2.53.2 generation |
| model/testing/*_mock_gen.go | Updated header comments and function comments (no fields format) |
| log/logger.go | Replaced PrintfWithoutMeta with PrintWithoutMeta and adjusted panic functions |
| evaluate/task/write-test_test.go | Updated expected error messages in tests |
| evaluate/task/transpile_test.go | Removed unmatched error message expectations |
| evaluate/evaluate_test.go | Updated expected evaluation output string |
| cmd/eval-dev-quality/cmd/command.go | Replaced logger.PrintfWithoutMeta with logger.PrintWithoutMeta |
| .github/workflows/job-test.yml | Changed Go setup to use go-version-file referencing go.mod |
| .github/workflows/job-lint.yml | Changed Go setup to use go-version-file referencing go.mod |
Files not reviewed (3)
- Dockerfile: Language not supported
- Makefile: Language not supported
- go.mod: Language not supported
bauersimon
reviewed
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.