Skip to content

Conversation

@dantleech
Copy link
Member

No description provided.

@lsmith77 lsmith77 added review and removed wip/poc labels Dec 16, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird. the parenthesis should be on the next line

@lsmith77
Copy link
Member

Hmm .. there is an issue with the slugifier tests .. locally they are passing with PHP 5.6.14

......FFF
Time: 15.57 seconds, Memory: 62.75Mb
There were 3 failures:
1) Symfony\Cmf\Bundle\BlogBundle\Tests\Unit\Util\PostsUtilTest::testSlugify with data set #2 ('je suis une dévelopeur web', 'je-suis-une-developeur-web')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'je-suis-une-dvelopeur-web'
+'je-suis-une-developeur-web'
/home/travis/build/symfony-cmf/BlogBundle/Tests/Unit/Util/PostsUtilTest.php:35
2) Symfony\Cmf\Bundle\BlogBundle\Tests\Unit\Util\PostsUtilTest::testSlugify with data set #3 ('foo!"  812391 !"£ %!"$£*%!"$£', 'foo-812391-lb-lblb')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'foo-812391'
+'foo-812391-lb-lblb'
/home/travis/build/symfony-cmf/BlogBundle/Tests/Unit/Util/PostsUtilTest.php:35
3) Symfony\Cmf\Bundle\BlogBundle\Tests\Unit\Util\PostsUtilTest::testSlugify with data set #4 ('ĉràzŷ& cĥärs', 'crazy-chars')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'rz-crs'
+'crazy-chars'

@dantleech
Copy link
Member Author

Personally I would be up for deprecating this whole bundle..

@lsmith77
Copy link
Member

well we never had a stable release ..

@dbu
Copy link
Member

dbu commented Dec 17, 2015 via email

@lsmith77
Copy link
Member

I agree that we can deprecate it ..

@dbu
Copy link
Member

dbu commented Apr 8, 2016

we abandoned this bundle now

@dbu dbu closed this Apr 8, 2016
@lsmith77 lsmith77 removed the review label Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants