[POC] Metadata and Annotation support #209
+571
−55
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Enhancer; | ||
|
|
||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Metadata\MetadataFactoryInterface; | ||
| use Symfony\Cmf\Component\Routing\Enhancer\RouteEnhancerInterface; | ||
|
|
||
| /** | ||
| * This enhancer performs the same role as its counterpart | ||
| * in the Routing component, but it uses the Metadata factory. | ||
| * | ||
| * @author Daniel Leech <daniel@dantleech.com> | ||
| */ | ||
| class FieldByClassEnhancer implements RouteEnhancerInterface | ||
|
There was a problem hiding this comment. This class is a new implementation which uses the Metadata factory. |
||
| { | ||
| /** | ||
| * @var string field for the className class | ||
| */ | ||
| protected $classField; | ||
|
|
||
| /** | ||
| * @var string field to write hashmap lookup result into | ||
| */ | ||
| protected $targetField; | ||
|
|
||
| /** | ||
| * @var string field to write hashmap lookup result into | ||
| */ | ||
| protected $metaField; | ||
|
|
||
| /** | ||
| * @var Metadata\MetadataFactoryInterface | ||
| */ | ||
| protected $metadataFactory; | ||
|
|
||
| /** | ||
| * @param string $className the field name of the class | ||
| * @param string $targetField the field name to set from the map | ||
| * @param array $map the map of class names to field values | ||
| */ | ||
| public function __construct( | ||
| $classField, | ||
| $targetField, | ||
| $metaField, | ||
|
There was a problem hiding this comment. targetField = field in There was a problem hiding this comment. hm, should the metadata not all be evaluated when the container is built? i would have expected that this metadata stuff is never used at runtime - thats potentially very expensive. There was a problem hiding this comment. I think the metadata should be "warmed up" like what happens in Doctrine. So there would be no overhead here, in production, for driver implementations which "know" about all of their mapped documents and are primed with a cache. The annotations would stil be evaluated lazily but would use a cached driver. |
||
| MetadataFactoryInterface $metadataFactory | ||
| ) | ||
| { | ||
| $this->classField = $classField; | ||
| $this->targetField = $targetField; | ||
| $this->metaField = $metaField; | ||
| $this->metadataFactory = $metadataFactory; | ||
| } | ||
|
|
||
| /** | ||
| * If the class name is mapped | ||
| * | ||
| * {@inheritDoc} | ||
| */ | ||
| public function enhance(array $defaults, Request $request) | ||
| { | ||
| if (isset($defaults[$this->targetField])) { | ||
| return $defaults; | ||
| } | ||
|
|
||
| // return if the field containg the class name has not been set | ||
| if (! isset($defaults[$this->classField])) { | ||
| return $defaults; | ||
| } | ||
|
|
||
| $className = get_class($defaults[$this->classField]); | ||
|
|
||
| $meta = $this->metadataFactory->getMetadataForClass($className); | ||
|
|
||
| if (null !== $meta) { | ||
| $meta = $meta->getOutsideClassMetadata(); | ||
| if (null !== $meta->{$this->metaField}) { | ||
| $defaults[$this->targetField] = $meta->{$this->metaField}; | ||
| } | ||
| } | ||
|
|
||
| return $defaults; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations; | ||
|
|
||
| /** | ||
| * @Annotation | ||
| */ | ||
| class Controller | ||
| { | ||
| public $controller; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations; | ||
|
|
||
| /** | ||
| * @Annotation | ||
| */ | ||
| class Template | ||
| { | ||
| public $resource; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata; | ||
|
|
||
| use Metadata\ClassMetadata as BaseClassMetadata; | ||
|
|
||
| class ClassMetadata extends BaseClassMetadata | ||
| { | ||
| public $template; | ||
| public $controller; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver; | ||
|
|
||
| use Metadata\Driver\DriverInterface; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\ClassMetadata; | ||
|
|
||
| abstract class AbstractDriver implements DriverInterface | ||
| { | ||
| public function validateMetadata(ClassMetadata $meta) | ||
| { | ||
| if ( | ||
| null !== $meta->template && | ||
| null == $meta->controller | ||
| ) { | ||
| throw new \InvalidArgumentException(sprintf( | ||
| 'Template specified for class "%s" but no controller specified.' .PHP_EOL. | ||
| 'You must either explicitly map a controller to the class or define'.PHP_EOL. | ||
| 'a "generic_controller" in the main configuration.' | ||
| , $meta->name)); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver; | ||
|
|
||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\ClassMetadata; | ||
| use Doctrine\Common\Annotations\Reader; | ||
|
|
||
| class AnnotationDriver extends AbstractDriver | ||
| { | ||
| protected $reader; | ||
| protected $genericController; | ||
|
|
||
| /** | ||
| * @param AnnotationReader $reader | ||
| */ | ||
| public function __construct(Reader $reader) | ||
| { | ||
| $this->reader = $reader; | ||
| } | ||
|
|
||
| public function setGenericController($genericController) | ||
| { | ||
| $this->genericController = $genericController; | ||
| } | ||
|
|
||
| public function loadMetadataForClass(\ReflectionClass $class) | ||
| { | ||
| $templateAnnotation = $this->reader->getClassAnnotation( | ||
| $class, | ||
| 'Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations\Template' | ||
| ); | ||
| $controllerAnnotation = $this->reader->getClassAnnotation( | ||
| $class, | ||
| 'Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations\Controller' | ||
| ); | ||
|
|
||
|
|
||
| $meta = new ClassMetadata($class->name); | ||
|
|
||
| if (null !== $templateAnnotation) { | ||
| $meta->template = $templateAnnotation->resource; | ||
| } | ||
|
|
||
| if (null !== $controllerAnnotation) { | ||
| $meta->controller = $controllerAnnotation->controller; | ||
| } | ||
|
|
||
| if (null === $meta->controller) { | ||
| $meta->controller = $this->genericController; | ||
| } | ||
|
|
||
| $this->validateMetadata($meta); | ||
|
There was a problem hiding this comment. AnnotationDriver validates lazily |
||
|
|
||
| return $meta; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver; | ||
|
|
||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\ClassMetadata; | ||
|
|
||
| /** | ||
| * Driver which operates from explicitly defined mappings | ||
| * | ||
| * @author Daniel Leech <daniel@dantleech.com> | ||
| */ | ||
| class ConfigurationDriver extends AbstractDriver | ||
| { | ||
| protected $reader; | ||
| protected $metadata = array(); | ||
|
|
||
| /** | ||
| * Eagerly loads the class metadata | ||
| */ | ||
| public function registerMapping($classFqn, $mapping) | ||
| { | ||
| $meta = new ClassMetadata($classFqn); | ||
|
|
||
| if (isset($mapping['template'])) { | ||
| $meta->template = $mapping['template']; | ||
| } | ||
|
|
||
| if (isset($mapping['controller'])) { | ||
| $meta->controller = $mapping['controller']; | ||
| } | ||
|
|
||
| $this->validateMetadata($meta); | ||
|
There was a problem hiding this comment. ConfigDriver is eager (validating when the mapping is registered). |
||
|
|
||
| $this->metadata[$classFqn] = $meta; | ||
| } | ||
|
|
||
| public function loadMetadataForClass(\ReflectionClass $class) | ||
| { | ||
| if (!isset($this->metadata[$class->name])) { | ||
| return null; | ||
| } | ||
|
|
||
| return $this->metadata[$class->name]; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <container xmlns="http://symfony.com/schema/dic/services" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
|
||
| <services> | ||
| <!-- Factory --> | ||
| <service | ||
| id="cmf_routing.metadata.factory" | ||
| class="Metadata\MetadataFactory" | ||
| > | ||
| <argument | ||
| type="service" | ||
| id="cmf_routing.metadata.driver.chain" | ||
| /> | ||
| </service> | ||
|
|
||
| <!-- Chain Driver !--> | ||
| <service | ||
| id="cmf_routing.metadata.driver.chain" | ||
|
There was a problem hiding this comment. I think I prefer using There was a problem hiding this comment. Well, I think <service id="twig.loader" alias="twig.loader.filesystem" /> |
||
| class="Metadata\Driver\DriverChain" | ||
| > | ||
| <argument type="collection"> | ||
| <argument type="service" id="cmf_routing.metadata.driver.configuration"/> | ||
| <argument type="service" id="cmf_routing.metadata.driver.annotation"/> | ||
| </argument> | ||
| </service> | ||
|
|
||
| <!-- Annotations Driver --> | ||
| <service | ||
| id="cmf_routing.metadata.driver.annotation" | ||
| class="Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver\AnnotationDriver" | ||
| > | ||
| <argument type="service" id="annotation_reader"/> | ||
| <argument type="collection"/> | ||
| </service> | ||
|
|
||
| <!-- Annotations Driver --> | ||
| <service | ||
| id="cmf_routing.metadata.driver.configuration" | ||
| class="Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver\ConfigurationDriver" | ||
| > | ||
| <argument type="collection"/> | ||
| </service> | ||
| </services> | ||
| </container> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony CMF package. | ||
| * | ||
| * (c) 2011-2013 Symfony CMF | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Tests\Functional\Metadata\Driver; | ||
|
|
||
| use Symfony\Component\HttpFoundation\RedirectResponse; | ||
|
|
||
| use Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr\Route; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr\RedirectRoute; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Controller\RedirectController; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Tests\Functional\BaseTestCase; | ||
|
|
||
| class AnnotationDriverTest extends BaseTestCase | ||
| { | ||
| public function setUp() | ||
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->chainDriver = $this->getContainer()->get('cmf_routing.metadata.factory'); | ||
| $this->annotDriver = $this->getContainer()->get('cmf_routing.metadata.driver.annotation'); | ||
| } | ||
|
|
||
| public function testDriverTemplateAndContent() | ||
| { | ||
| $meta = $this->chainDriver->getMetadataForClass( | ||
| 'Symfony\Cmf\Bundle\RoutingBundle\Tests\Resources\Document\AnnotatedContent' | ||
| ); | ||
|
|
||
| $this->assertNotNull($meta); | ||
|
|
||
| $meta = $meta->getOutsideClassMetadata(); | ||
|
|
||
| $this->assertEquals('TestBundle:Content:index.html.twig', $meta->template); | ||
| $this->assertEquals('ThisIsAController', $meta->controller); | ||
| } | ||
|
|
||
| public function testDriverTemplateOnlyWithGenericController() | ||
| { | ||
| $meta = $this->chainDriver->getMetadataForClass( | ||
| 'Symfony\Cmf\Bundle\RoutingBundle\Tests\Resources\Document\AnnotatedContentTemplateOnly' | ||
| ); | ||
|
|
||
| $this->assertNotNull($meta); | ||
|
|
||
| $meta = $meta->getOutsideClassMetadata(); | ||
|
|
||
| $this->assertEquals('TestBundle:Content:index.html.twig', $meta->template); | ||
| $this->assertEquals('cmf_content.controller:indexAction', $meta->controller); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException InvalidArgumentException | ||
| * @expectedExceptionMessage but no controller specified | ||
| */ | ||
| public function testDriverTemplateOnlyNoController() | ||
| { | ||
| $this->annotDriver->setGenericController(null); | ||
| $meta = $this->chainDriver->getMetadataForClass( | ||
| 'Symfony\Cmf\Bundle\RoutingBundle\Tests\Resources\Document\AnnotatedContentTemplateOnly' | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony CMF package. | ||
| * | ||
| * (c) 2011-2013 Symfony CMF | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Tests\Resources\Document; | ||
|
|
||
|
|
||
|
|
||
| use Doctrine\ODM\PHPCR\Mapping\Annotations as PHPCRODM; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations as CmfRouting; | ||
|
|
||
| /** | ||
| * @PHPCRODM\Document(referenceable=true) | ||
| * | ||
| * @CmfRouting\Template("TestBundle:Content:index.html.twig") | ||
| * @CmfRouting\Controller("ThisIsAController") | ||
| */ | ||
| class AnnotatedContent | ||
| { | ||
| /** | ||
| * @PHPCRODM\Id | ||
| */ | ||
| public $path; | ||
|
|
||
| /** | ||
| * PHPCRODM\String() | ||
| */ | ||
| public $title; | ||
|
|
||
| public function setId($path) | ||
| { | ||
| $this->path = $path; | ||
| } | ||
|
|
||
| public function setTitle($title) | ||
| { | ||
| $this->title = $title; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony CMF package. | ||
| * | ||
| * (c) 2011-2013 Symfony CMF | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
|
|
||
| namespace Symfony\Cmf\Bundle\RoutingBundle\Tests\Resources\Document; | ||
|
|
||
|
|
||
| use Doctrine\ODM\PHPCR\Mapping\Annotations as PHPCRODM; | ||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\Annotations as CmfRouting; | ||
|
|
||
| /** | ||
| * @PHPCRODM\Document(referenceable=true) | ||
| * | ||
| * @CmfRouting\Template("TestBundle:Content:index.html.twig") | ||
| */ | ||
| class AnnotatedContentTemplateOnly | ||
| { | ||
| /** | ||
| * @PHPCRODM\Id | ||
| */ | ||
| public $path; | ||
|
|
||
| /** | ||
| * PHPCRODM\String() | ||
| */ | ||
| public $title; | ||
|
|
||
| public function setId($path) | ||
| { | ||
| $this->path = $path; | ||
| } | ||
|
|
||
| public function setTitle($title) | ||
| { | ||
| $this->title = $title; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php | ||
|
|
||
| namespace Unit\Metadata\Driver; | ||
|
|
||
| use Symfony\Cmf\Bundle\RoutingBundle\Metadata\Driver\ConfigurationDriver; | ||
|
|
||
| class ConfigurationDriverTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| protected $driver; | ||
|
|
||
| public function setUp() | ||
| { | ||
| $this->driver = new ConfigurationDriver; | ||
| } | ||
|
|
||
| public function testDriver() | ||
| { | ||
| $this->driver->registerMapping('stdClass', array( | ||
| 'template' => 'foobar.html.twig', | ||
| 'controller' => 'FoobarController', | ||
| )); | ||
|
|
||
| $refl = new \ReflectionClass('stdClass'); | ||
| $meta = $this->driver->loadMetadataForClass($refl); | ||
|
|
||
| $this->assertEquals('foobar.html.twig', $meta->template); | ||
| $this->assertEquals('FoobarController', $meta->controller); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException InvalidArgumentException | ||
| * @expectedExceptionMessage but no controller specified | ||
| */ | ||
| public function testDriverMissingController() | ||
| { | ||
| $this->driver->registerMapping('stdClass', array( | ||
| 'template' => 'foobar.html.twig', | ||
| )); | ||
|
|
||
| $refl = new \ReflectionClass('stdClass'); | ||
| $meta = $this->driver->loadMetadataForClass($refl); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -19,6 +19,10 @@ | ||
| <testsuite name="orm"> | ||
| <directory>./Tests/Functional/Doctrine/Orm</directory> | ||
| </testsuite> | ||
|
|
||
| <testsuite name="metadata"> | ||
|
There was a problem hiding this comment. @wouterj - I added this, is it worth it? There was a problem hiding this comment. otherwise the database is purged and reloaded on each test |
||
| <directory>./Tests/Functional/Metadata</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
|
|
||
| <filter> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The the validation for this mapping will be triggered the first time the configuration driver is instantiated. So it is not as early as you might want, but it the validation is eager and not lazy. See the ConfigurationDriver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still means we have to run the validation at runtime rather than compile time, which imho sucks. can't we keep validating here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would, I think, mean doing the same validation in two places. I guess one way around this problem would be to listen to a cache warming event or similar, that way drivers which are capable of validating their mapped objects (e.g. DI driver, XML, YAML and annotations when possible) can do so eagerly?