This repository was archived by the owner on Sep 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
DevKit updates #139
Open
ElectricMaxxx
wants to merge
23
commits into
master
Choose a base branch
from
master-dev-kit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DevKit updates #139
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
98be656
DevKit updates
ElectricMaxxx b3f99d4
try to get composer running with more memory
ElectricMaxxx 3537b94
use php to execute composer
ElectricMaxxx 62aacbc
use composer constant
ElectricMaxxx 8ddd842
replase ckeditor
ElectricMaxxx ad3e2e2
use fork for sonata admin
ElectricMaxxx 72306e6
DevKit updates
ElectricMaxxx 5d0be79
introduce fos_ckeditor
ElectricMaxxx 493bfa4
[ISSUE-3] more explicit version on one step before Frontend Schlitten…
ElectricMaxxx 17592ba
increase testing version
ElectricMaxxx 639a65a
DevKit updates
ElectricMaxxx 450b7d3
better ckeditor version
ElectricMaxxx 814e787
first movement of some test classes
ElectricMaxxx 5e3d463
DevKit updates
ElectricMaxxx 4519fdc
DevKit updates
ElectricMaxxx 6d75cf1
DevKit updates
ElectricMaxxx 62f17f8
repair composer.json
ElectricMaxxx 27cf604
DevKit updates
ElectricMaxxx 44d11ad
DevKit updates
ElectricMaxxx f3c62d4
DevKit updates
ElectricMaxxx 1dd14f1
DevKit updates
ElectricMaxxx 989dc09
higher testing lib. versions
ElectricMaxxx 8e58e38
cs fixes for php and its strictness
ElectricMaxxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
--- | ||
name: Bug Report | ||
about: Report errors and problems | ||
|
||
--- | ||
|
||
<!-- | ||
The Symfony Code of Conduct applies to all the activity on this repository. | ||
See https://symfony.com/doc/current/contributing/code_of_conduct/index.html | ||
--> | ||
|
||
**Description** | ||
<!-- A clear and concise description of the problem. --> | ||
|
||
**How to reproduce** | ||
<!-- Code and/or config needed to reproduce the problem. If it's a complex bug, | ||
create a "bug reproducer" as explained in: | ||
https://symfony.com/doc/current/contributing/code/reproducer.html --> | ||
|
||
**Possible Solution** | ||
<!--- Optional: only if you have suggestions on a fix/reason for the bug --> | ||
|
||
**Additional context** | ||
<!-- Optional: any other context about the problem: log messages, screenshots, etc. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
name: Documentation Issue | ||
about: Anything related to Symfony CMF Documentation | ||
|
||
--- | ||
|
||
Symfony CMF Documentation has its own dedicated repository. Please open your | ||
documentation-related issue at https://github.com/symfony-cmf/symfony-cmf-docs/issues | ||
|
||
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
name: Feature Request | ||
about: RFC and ideas for new features and improvements | ||
|
||
--- | ||
|
||
**Description** | ||
<!-- A clear and concise description of the new feature. --> | ||
|
||
**Example** | ||
<!-- A simple example of the new feature in action (include PHP code, YAML config, etc.) | ||
If the new feature changes an existing feature, include a simple before/after comparison. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
name: Security Issue | ||
about: Report security-related errors | ||
|
||
--- | ||
|
||
If you have found a security issue in Symfony, please send the details to | ||
[David](mailto:[email protected]) or [Maximilian](mailto:[email protected]) and don't disclose it publicly until we can provide a | ||
fix for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
name: Support Question | ||
about: Questions about using Symfony CMF and its components | ||
|
||
--- | ||
|
||
**Description** | ||
<!-- A clear and concise description of the problem. --> | ||
|
||
**How to reproduce (optional)** | ||
<!-- Optional: Only if you have something to reproduce. Code and/or config needed to reproduce the problem. --> | ||
|
||
**Possible Solution** | ||
<!-- Optional: only if you have suggestions to solve it --> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
|
||
namespace Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\Tests\Unit\DependencyInjection\Factory; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Cmf\Bundle\SonataPhpcrAdminIntegrationBundle\DependencyInjection\Factory\ContentAdminFactory; | ||
use Symfony\Component\Config\Definition\Builder\TreeBuilder; | ||
use Symfony\Component\Config\Definition\Processor; | ||
|
@@ -21,7 +22,7 @@ | |
* @author Wouter de Jong <[email protected]> | ||
* @author Maximilian Berghoff <[email protected]> | ||
*/ | ||
class ContentAdminFactoryTest extends \PHPUnit_Framework_TestCase | ||
class ContentAdminFactoryTest extends TestCase | ||
{ | ||
private $factory; | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
memory_limit = -1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this into phpunit.xml.dist so the tests run locally. you can remove KERNEL_DIR in phpunit.xml.dist, because that is no longer used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: the variable is also exported in make file :-)