Skip to content

[Store][WIP] Implement remove method for SurrealDb store #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[Store][WIP] Implement remove method for SurrealDb store #1512

Copilot wants to merge 4 commits into from
+212 −1

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026 •
edited
Loading

Implementation Plan

  • Understand SurrealDB delete syntax and API
  • Implement remove() method in Store.php
  • Add test cases for remove() method
  • Update implementation to use SQL endpoint with DELETE statement
  • Batch DELETE statements into single request instead of foreach loop
  • Run tests to validate implementation
  • Fix any issues found during testing

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@OskarStark OskarStark added the Store Issues & PRs about the AI Store component label Jan 28, 2026
@carsonbot carsonbot changed the title [WIP] Implement remove method for SurrealDb store [Store][WIP] Implement remove method for SurrealDb store Jan 28, 2026
@chr-hertel
Changes before error encountered
1c1da3b 
Co-authored-by: chr-hertel <2852185+chr-hertel@users.noreply.github.com>
Copilot AI requested a review from chr-hertel January 28, 2026 21:41
@chr-hertel chr-hertel added the Feature New feature label Jan 28, 2026
@chr-hertel chr-hertel mentioned this pull request Jan 28, 2026
Closed
chr-hertel
chr-hertel requested changes Feb 6, 2026
View reviewed changes
src/store/src/Bridge/SurrealDb/Store.php Outdated
Comment on lines 78 to 80
foreach ($ids as $id) {
$this->request('DELETE', \sprintf('key/%s/%s', $this->table, $id), []);
}
Copy link
Member

@chr-hertel chr-hertel Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the sql endpoint with a DELETE statement, see https://surrealdb.com/docs/surrealql/statements/delete

Copy link
Contributor Author

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use the sql endpoint with a DELETE statement as suggested. The implementation now uses DELETE table:id; syntax. (4c248de)

Copy link
Member

@chr-hertel chr-hertel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we batch it into one statement and skip the foreach loop?

Copy link
Member

@chr-hertel chr-hertel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Copy link
Contributor Author

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batched all IDs into a single DELETE statement. Now using DELETE table:id1, table:id2, table:id3; syntax instead of multiple requests. (a687751)

@chr-hertel
Use SQL endpoint with DELETE statement for remove() method
4c248de 
Co-authored-by: chr-hertel <2852185+chr-hertel@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 6, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/JetBrains/phpstorm-stubs/zipball/d1ee5e570343bd4276a3d5959e6e1c2530b006d0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/PHP-CS-Fixer/shim/zipball/3a9db22e8f01762fddd3a85b998053294c5a3629
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/composer/pcre/zipball/b2bed4734f0cc156ee1fe9c0da2550420d99a21e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/composer/xdebug-handler/zipball/6c1925561632e83d60a44492e0b344cf48ab85ef
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/deptrac/deptrac/zipball/b27bfc5291a1cbe1c0ebf514716b1d25c68c63fd
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/doctrine/deprecations/zipball/459c2f5dd3d6a4633d3b5f46ee2b1c40f57d3f38
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-fig/event-dispatcher/zipball/dbefd12671e8a14ec7f180cab83036ed26714bb0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpDocumentor/GraphViz/zipball/115999dc7f31f2392645aa825a94a6b165e1cedf
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpDocumentor/ReflectionCommon/zipball/1d01c49d4ed62f25aa84a747ad35d5a16924662b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpDocumentor/TypeResolver/zipball/327a05bbee54120d4786a0dc67aad30226ad4cf9
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpstan/phpdoc-parser/zipball/a004701b11273a26cd7955a61d67a7f1e525a45a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phpstan/phpstan/zipball/dfaf1f530e1663aa167bc3e52197adb221582629
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/config/zipball/4275b53b8ab0cf37f48bf273dc2285c8178efdfb
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/console/zipball/41e38717ac1dd7a46b6bda7d6a82af2d98a78894
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/dependency-injection/zipball/76a02cddca45a5254479ad68f9fa274ead0a7ef2
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/59eb412e93815df44f05f342958efa9f46b1e586
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/event-dispatcher/zipball/dc2c0eba1af673e736bb851d747d266108aea746
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/filesystem/zipball/d551b38811096d0be9c4691d406991b47c0c630a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/finder/zipball/ad4daa7c38668dcb031e63bc99ea9bd42196a2cb
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/polyfill-intl-grapheme/zipball/380872130d3a5dd3ace2f4010d95125fde5d5c70
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/polyfill-intl-normalizer/zipball/3833d7255cc303546435cb650316bff708a1c75c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/service-contracts/zipball/45112560a3ba2d715666a509a0bc9521d10b6c43
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/string/zipball/1c4b10461bf2ec27537b5f36105337262f5f5d6f
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/var-exporter/zipball/03a60f169c79a28513a78c967316fbc8bf17816f
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/yaml/zipball/24dd4de28d2e3988b311751ac49e684d783e2345
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/VYvch5 /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from chr-hertel February 6, 2026 23:51
chr-hertel
chr-hertel reviewed Feb 7, 2026
View reviewed changes
src/store/src/Bridge/SurrealDb/bootstrap.php
Copy link
Member

@chr-hertel chr-hertel Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@chr-hertel
Batch DELETE statements into single request
a687751 
Co-authored-by: chr-hertel <2852185+chr-hertel@users.noreply.github.com>
Copilot AI requested a review from chr-hertel February 7, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark will be requested when the pull request is marked ready for review OskarStark is a code owner

Assignees

@chr-hertel chr-hertel

Copilot code review Copilot

Labels

Feature New feature Status: Needs Review Store Issues & PRs about the AI Store component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chr-hertel @OskarStark @carsonbot