[Store][WIP] Implement remove method for Weaviate store #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Contributor
|
@copilot remove the |
Co-authored-by: OskarStark <995707+OskarStark@users.noreply.github.com>
Co-authored-by: OskarStark <995707+OskarStark@users.noreply.github.com>
chr-hertel
requested changes
Feb 6, 2026
Comment on lines
73
to
75
| foreach ($ids as $id) { | ||
| $this->request('DELETE', \sprintf('v1/objects/%s', $id), []); | ||
| } |
Member
There was a problem hiding this comment.
The API supports delete in batch on /v1/batch/objects endpoint, please use it:
https://docs.weaviate.io/weaviate/api/rest#tag/batch/POST/batch/objects
Co-authored-by: chr-hertel <2852185+chr-hertel@users.noreply.github.com>
chr-hertel
reviewed
Feb 7, 2026
Comment on lines
+71
to
+74
| $objects = array_map(fn (string $id) => [ | ||
| 'class' => $this->collection, | ||
| 'id' => $id, | ||
| ], $ids); |
Member
There was a problem hiding this comment.
naah, this payload looks wrong to me 🤔
https://docs.weaviate.io/weaviate/api/rest#tag/batch/DELETE/batch/objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.