[Agent] improv: Better defaults, preserve tool msgs #1553
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Agent
aszenz
force-pushed
the
change/preserve-tool-msgs-by-default
branch
from
d8353aa to
10ba7f5
Compare
Member
|
Let's keep it here, but should we rename it to |
aszenz
force-pushed
the
change/preserve-tool-msgs-by-default
branch
2 times, most recently
from
c348a2c to
b99ce14
Compare
chr-hertel
reviewed
Feb 9, 2026
| private readonly ToolResultConverter $resultConverter = new ToolResultConverter(), | ||
| private readonly ?EventDispatcherInterface $eventDispatcher = null, | ||
| private readonly bool $keepToolMessages = false, | ||
| private readonly bool $keepToolMessages = true, |
Member
There was a problem hiding this comment.
meant this as well:
Suggested change
| private readonly bool $keepToolMessages = true, | |
| private readonly bool $excludeToolMessage = false, |
needs a invert of the logic below
aszenz
force-pushed
the
change/preserve-tool-msgs-by-default
branch
2 times, most recently
from
46dd60b to
aab79a2
Compare
aszenz
force-pushed
the
change/preserve-tool-msgs-by-default
branch
from
aab79a2 to
2535f83
Compare
chr-hertel
approved these changes
Feb 9, 2026
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Thanks @aszenz - quite a change when it comes to token consumption, but the right default - i hope :D
I think we should still add a note in the UPGRADE.md - good to be merged after that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not sure if we should change the default or remove this option altogether and move it to compression feature in #1549