[Platform] Make JSON schema generation extensible #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
valtzu
force-pushed
the
schema-refactor
branch
from
e9b5e6b to
2eda852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange schema generation logic to allow extending it. I tried not to change any logic, the fact that
FactoryTestis untouched and still passing should indicate it succeeded.After this it will be possible to add optional
ValidatorConstraintDescriberthat amends the schema based on Symfony Validator metadata.NOTE: does not include changes from #1557
I would really like if "normal" Serializer behavior worked here, e.g. getters and setters. If this support is planned, the proposed interface here would not work.
In general this probably needs some more work