[Store] Remove UID as type from Documents ID #1575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
added
Store
chr-hertel
force-pushed
the
store-remove-uid
branch
from
88d08fe to
0037501
Compare
chr-hertel
force-pushed
the
store-remove-uid
branch
from
0037501 to
fdbecc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a bit controversial, but while working on #1563 I stumbled on a few store implementations strongly assuming that
idis aUuideven tho we opened it tostring|int|Uuidwith #1397 - and i still thinkgint|stringis def needed here.