[Store] Replace public properties by private+getters for BC promise #1577
+414
−379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
store-public-props
branch
3 times, most recently
from
1929c29 to
19b7be9
Compare
chr-hertel
force-pushed
the
store-public-props
branch
from
19b7be9 to
111a2ec
Compare
Member
|
This diff makes me sad. While PHP is moving in the opposite direction with property hooks, we're reintroducing getter functions. 😞 |
OskarStark
reviewed
Feb 9, 2026
| -$rssItem->title; | ||
| +$rssItem->getTitle(); | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
metadata -> getMetadata()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing BC promise issues with public properties with
VectorDocumentandRssItem