[Chat][Doctrine] Replace row-accumulation in DoctrineDbalMessageStore#1987
Open
Tiriel wants to merge 2 commits intosymfony:mainfrom
Open
[Chat][Doctrine] Replace row-accumulation in DoctrineDbalMessageStore#1987Tiriel wants to merge 2 commits intosymfony:mainfrom
Tiriel wants to merge 2 commits intosymfony:mainfrom
Conversation
carsonbot
added
Status: Needs Review
Chat
Contributor
Author
|
Note: Schema changed because |
Contributor
Author
|
The Fabpot fail seems to be a false positive, it flags |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace row-accumulation with single-row upsert in DoctrineDbalMessageStore.
Until now, DoctrineDbalMessage was accumulating messages in new rows. Each row contained all the previous messages plus the new ones, leading to exponential growth of context, warped message history, and profiler exhaustion.
This aims to address this problem and align the message store's design with the other stores'.