[Store][Elasticsearch] Introduce a StoreFactory - #2199
Conversation
c95110d to
6d44a94
Compare
carsonbot
added
Feature
|
@OskarStark @chr-hertel Do we have an estimated release date for PS: I have a few PRs using the same approach as this one on my local fork and wanted to know if we have a specific deadline. |
|
@Guikingone i think i'm saying "in the next four weeks" since march now - doesn't help i guess, sorry 😆 edit: so, in the next four weeks :) |
There was a problem hiding this comment.
should be reduced to BC breaks only, and for 0.11
|
@chr-hertel Well, now I know that I have one month to push as much PR as possible if I want them to be merged in i'll push all the PR that I have locally and update the existing ones, thanks for the update 🙂 |
6d44a94 to
d762987
Compare
d762987 to
d04638b
Compare
The `Store` constructor now expects a pre-scoped `HttpClientInterface`; endpoint scoping is performed by `StoreFactory::create()` via `ScopingHttpClient::forBaseUri()`. The `AiBundle` wiring switches to the factory.
d04638b to
5d34960
Compare
| ): StoreInterface&ManagedStoreInterface { | ||
| $httpClient ??= HttpClient::create(); | ||
|
|
||
| if (null !== $endpoint) { |
There was a problem hiding this comment.
this part needs to cover the rtrim that got removed in Store constructor now
| * } $document | ||
| * @param array<mixed> $document | ||
| */ | ||
| private function convertToVectorDocument(array $document): VectorDocument |
There was a problem hiding this comment.
this part of the diff is missing from PR title/description and changelog? what's the goal/scope here? is it potentially a different PR?
There was a problem hiding this comment.
those new exceptions need tests, please
4 participants
The
Storeconstructor now expects a pre-scopedHttpClientInterface; endpoint scoping is performed byStoreFactory::create()viaScopingHttpClient::forBaseUri(). TheAiBundlewiring switches to the factory.