[Platform] Add provider identity to ResultConvertedEvent and ResultErrorEvent - #2467
Open
clegginabox wants to merge 1 commit into
Open
[Platform] Add provider identity to ResultConvertedEvent and ResultErrorEvent#2467clegginabox wants to merge 1 commit into
clegginabox wants to merge 1 commit into
Conversation
carsonbot
added
Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Platform can hold several providers, but a listener on
ResultConvertedEvent/ResultErrorEventcan't tell which provider actually served the request.This adds an optional
?ProviderInterface $providerto both events (with agetProvider(): ?ProviderInterfacegetter), andProvidernow passes itself when dispatching them.I need this to rework #1452: capacity is acquired when routing picks a provider and a listener on these events releases it when a result resolves. This will only work if the event says which provider's capacity to release.