[make:decorator] Add new maker to create decorator

[WedgeSama]

Add new maker to create decorator.
#1401

Allow to create new decorator for existing services.

It try first to decorate by implements:

• The service ID used is an interface => implements this interface
• The service class implements one (or more) interface(s) and it do not declare more public method => implements those interfaces

If cannot implements, it will fallback to extends:

• Simply extends the service's class
• Do not work for final class

e.g.

bin/console make:decorator Symfony\Component\Routing\Generator\UrlGeneratorInterface MyUrlGenerator

<?php

namespace App;

use Symfony\Component\DependencyInjection\Attribute\AsDecorator;
use Symfony\Component\DependencyInjection\Attribute\AutowireDecorated;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Routing\RequestContext;

#[AsDecorator(UrlGeneratorInterface::class)]
final class MyUrlGenerator implements UrlGeneratorInterface
{
    public function __construct(
        #[AutowireDecorated]
        private readonly UrlGeneratorInterface $inner,
    ) {
    }

    public function generate(string $name, array $parameters = [], int $referenceType = self::ABSOLUTE_PATH): string
    {
        return $this->inner->generate($name, $parameters, $referenceType);
    }

    public function setContext(RequestContext $context): void
    {
        $this->inner->setContext($context);
    }

    public function getContext(): RequestContext
    {
        return $this->inner->getContext();
    }
}

[Neirda24]

Suggested change

	$shortNameMap[$shortClass][] = $id;
	$shortNameMap[$shortClass] ??= [];
	$shortNameMap[$shortClass][] = $id;

I know it works without but I d'ont find it very readable to not explictly create the array. Maybe it is acceptable in the maker bundle.

[Neirda24]

Maybe you meant to use https://www.php.net/manual/en/function.array-walk.php instead ?

[Neirda24]

Suggested change

	if (\in_array($id, $this->ids)) {
	if (\in_array($id, $this->ids, true)) {

[Neirda24]

Suggested change

	$id = $io->choice(\sprintf('Multiple services found for "%s", choice which one you want to decorate?', $id), $guessRealIds),
	$id = $io->choice(\sprintf('Multiple services found for "%s", choose which one you want to decorate:', $id), $guessRealIds),

[Neirda24]

should probably be a static list IMO. IT didn't changed for quite some time and won't be changed anytime soon I think. Keep it simple.

[Neirda24]

is variadic also supported ?

[Neirda24]

Suggested change

	throw new RuntimeCommandException('Should never be reach.');
	throw new RuntimeCommandException('Should never be reached.');

[GromNaN]

Thank you for this maker, it fits well within the project's scope for a feature that's genuinely tricky to get right by hand.

Since this branch conflicts with the config changes merged into 1.x since (XML config moved to PHP, help files restructured), I rebased it and applied the remaining review feedback from @Neirda24 (strict in_array, explicit short name map initialization, choice prompt wording, static map for onInvalid constants, variadic parameter support, exception message typo) in #1807.

Feel free to have a look, and let me know if you'd rather continue on this branch instead.

[WedgeSama]

Sorry, I was in holiday 😅
No problem @GromNaN 😉