Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for php-bug-catcher/bug-catcher #1659

Closed
wants to merge 4 commits into from

Conversation

tito10047
Copy link

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 19, 2024 19:32
Copy link

github-actions bot commented Aug 19, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1659/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1659/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'php-bug-catcher/bug-catcher:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled August 19, 2024 19:43

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 19, 2024 19:43
auto-merge was automatically disabled August 19, 2024 19:48

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 19, 2024 19:48
auto-merge was automatically disabled August 19, 2024 19:56

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 19, 2024 19:56
@tito10047
Copy link
Author

tito10047 commented Aug 19, 2024

My bundle is not only bundle, but whole application. and is target only for php 8.3 and symfony 7.1. so I can't pass your tests

@tito10047
Copy link
Author

I can't get work this recipie.
this is in console Configuring php-bug-catcher/bug-catcher (>=1.0): From github.com/symfony/recipes-contrib:main so is good, but recipie is nt executed.

when ai run command composer recipes:update php-bug-catcher/bug-catcher
this error is writed:
Failed to download recipe: The "https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1659/archived/php-bug-catcher.bug-catcher/d3f48ef31320f551bbb8ebc3937d7615f01405dd.json" file could not be downloaded (HTTP/2 404 )

@fabpot
Copy link
Member

fabpot commented Aug 21, 2024

A recipe should only be about the package you configure. Here, you have too many other configs. That cannot be merged as is.

@tito10047
Copy link
Author

Yes, but this is not a package, this is the entire application. An application that you can easily expand with your own code.

If you can't merge it, close this PR.

But it's annoying to force people to set all this settings manually when they want to run my application. just see how huge is docs for this first run docs

Do you have any recommendations on how to do it better?

@OskarStark
Copy link
Contributor

You can create and provide a setup command, creating such config?

@tito10047
Copy link
Author

Ok, I will try, thanks :)

@tito10047 tito10047 closed this Aug 21, 2024
auto-merge was automatically disabled August 21, 2024 07:26

Pull request was closed

@tito10047
Copy link
Author

You can create and provide a setup command, creating such config?

This is good idea, but can't be work.

When I install my budnle, then project is broken because missing configuration required for this bundle. So I can't run command which need to generate this config.

Any other idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants