[CI] Test the suite against Node.js 22, 24 and 26 - #11
Merged
Conversation
Add a node-version matrix (22, 24, 26) to the test job so the JS suite runs on every supported major across the three OSes, replacing the single .nvmrc-pinned run. Declare the same support in both package.json "engines" fields, switching to the enumerated LTS-major form Webpack Encore uses (^22.18.0 || ^24.11.0 || >=26.0) so the odd, non-LTS majors are excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob used to run on a single Node version pinned by.nvmrc(Node 22). This PR adds a version matrix instead, testing Node 22, 24 and 26 across the three OSes we already cover (ubuntu, windows, macos), with readable job names like "Node 24 on ubuntu-latest". Thelintjob keeps using.nvmrc, no need to matrix that one.engines.nodein both the rootpackage.jsonandassets/package.json(the published@symfony/reprise) now declares the same support, using the enumerated form Webpack Encore uses:^22.18.0 || ^24.11.0 || >=26.0. This is stricter than the previous>=22.18on the published package since it excludes the odd, non-LTS majors (23, 25). The rootpackage.jsonhad noenginesfield at all before.This mirrors how
symfony/webpack-encoredeclares and tests its supported Node versions. Ran the suite locally on Node 22.18.0 (the floor of the range) and it passes.