Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Documented the ability to use transactions while sending messages with AMQP #18919

Open
wants to merge 2 commits into
base: 6.4
Choose a base branch
from

Conversation

michalsitek
Copy link

No description provided.

Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one
you will also need to add a version added directive to state that this option is v6.4+

@94noni
Copy link
Contributor

94noni commented Sep 22, 2023

of course!
here is an example, you can search in your edited file something "was introduced in Symfony 6.1."
just after some tables

@michalsitek
Copy link
Author

CI / Build ends up with

Found invalid reference "/messenger/handler_results" in file "messenger"

due to that file missing in 6.4. The last version it's available is 6.2: https://github.com/symfony/symfony-docs/blob/6.2/messenger/handler_results.rst

Any idea how can I fix this?

@94noni
Copy link
Contributor

94noni commented Sep 22, 2023

I think it should be removed on previous version and upmerged

@javiereguiluz javiereguiluz added Waiting Code Merge Docs for features pending to be merged Messenger labels Sep 26, 2023
@javiereguiluz javiereguiluz added this to the 6.4 milestone Sep 26, 2023
@carsonbot carsonbot modified the milestones: 6.4, next Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Messenger Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants